Skip to content

Conversation

@MihaiCristianCondrea
Copy link
Owner

Summary

  • swap Kotlin coroutines for AndroidX WorkManager in license loader
  • add WorkManager dependency and remove coroutine library
  • cancel outstanding work and HTTP resources when app terminates

Testing

  • ./gradlew test (fails: SDK location not found)

https://chatgpt.com/codex/tasks/task_e_68c682811bf4832da4adef8bf657dbf5

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +71 to +73
static class LoadHtmlWorker extends Worker {
LoadHtmlWorker(@NonNull Context context, @NonNull WorkerParameters params) {
super(context, params);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Expose LoadHtmlWorker publicly so WorkManager can instantiate it

The new worker is declared as static class LoadHtmlWorker with a package‑private constructor. WorkManager creates workers by reflection and requires both the class and its (Context, WorkerParameters) constructor to be public. With the current visibility it will throw an IllegalAccessException/NoSuchMethodException when the work runs, the request will immediately fail, and the callback observes empty output. Making the worker public static and its constructor public allows WorkManager to execute the job.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants