Refactor icon frame handling in preferences

This commit removes the explicit `iconFrame` `FrameLayout` from `item_preference.xml` and updates the logic in `AndroidStudioFragment.java` and `SettingsFragment.java` to directly manage the visibility of the icon `ImageView`.

- In `AndroidStudioFragment.java`, removed references and visibility updates for `iconFrame`.
- In `SettingsFragment.java`, updated `syncAccessoryVisibility` to set the visibility of the icon directly instead of its parent `iconFrame`.
- In `item_preference.xml`, removed the `FrameLayout` with ID `@android:id/icon_frame` and moved its layout attributes to the `ShapeableImageView` with ID `@android:id/icon`.

Author: MihaiCristianCondrea

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/AndroidStudioFragment.java

@@ -430,7 +430,6 @@ static class LessonHolder extends RecyclerView.ViewHolder {
             final MaterialTextView summary;
             final FrameLayout widgetFrame;
             final MaterialButton externalButton;
-            final FrameLayout iconFrame;
 
             LessonHolder(@NonNull View itemView) {
                 super(itemView);
@@ -439,7 +438,6 @@ static class LessonHolder extends RecyclerView.ViewHolder {
                 title = itemView.findViewById(android.R.id.title);
                 summary = itemView.findViewById(android.R.id.summary);
                 widgetFrame = itemView.findViewById(android.R.id.widget_frame);
-                iconFrame = itemView.findViewById(android.R.id.icon_frame);
                 LayoutInflater.from(itemView.getContext())
                         .inflate(R.layout.item_preference_widget_open_in_new, widgetFrame, true);
                 externalButton = widgetFrame.findViewById(R.id.open_in_new);
@@ -449,14 +447,8 @@ void bind(Lesson lesson, boolean first, boolean last) {
                 if (lesson.iconRes != 0) {
                     icon.setImageResource(lesson.iconRes);
                     icon.setVisibility(View.VISIBLE);
-                    if (iconFrame != null) {
-                        iconFrame.setVisibility(View.VISIBLE);
-                    }
                 } else {
                     icon.setVisibility(View.GONE);
-                    if (iconFrame != null) {
-                        iconFrame.setVisibility(View.GONE);
-                    }
                 }
                 title.setText(lesson.title);
                 if (lesson.summary != null) {

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/settings/SettingsFragment.java

@@ -317,10 +317,9 @@ private void applyRoundedCorners(@NonNull MaterialCardView card, boolean first,
 
     private void syncAccessoryVisibility(@NonNull View itemView) {
         View icon = itemView.findViewById(android.R.id.icon);
-        View iconFrame = itemView.findViewById(android.R.id.icon_frame);
-        if (iconFrame != null) {
-            boolean showIcon = icon != null && icon.getVisibility() == View.VISIBLE;
-            iconFrame.setVisibility(showIcon ? View.VISIBLE : View.GONE);
+        boolean showIcon = icon != null && icon.getVisibility() == View.VISIBLE;
+        if (icon != null) {
+            icon.setVisibility(showIcon ? View.VISIBLE : View.GONE);
         }
         View widgetFrame = itemView.findViewById(android.R.id.widget_frame);
         if (widgetFrame instanceof ViewGroup) {

app/src/main/res/layout/item_preference.xml

@@ -17,27 +17,18 @@
         android:orientation="horizontal"
         android:padding="12dp">
 
-        <FrameLayout
-            android:id="@android:id/icon_frame"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_gravity="center_vertical"
+        <com.google.android.material.imageview.ShapeableImageView
+            android:id="@android:id/icon"
+            android:layout_width="36dp"
+            android:layout_height="36dp"
             android:layout_marginEnd="16dp"
+            android:background="?attr/colorPrimaryContainer"
+            android:contentDescription="@null"
+            android:scaleType="centerCrop"
             android:visibility="gone"
-            tools:visibility="visible">
-
-            <com.google.android.material.imageview.ShapeableImageView
-                android:id="@android:id/icon"
-                android:layout_width="36dp"
-                android:layout_height="36dp"
-                android:background="?attr/colorPrimaryContainer"
-                android:contentDescription="@null"
-                android:scaleType="centerCrop"
-                android:visibility="gone"
-                app:contentPadding="6dp"
-                app:shapeAppearanceOverlay="@style/ShapeAppearance.Material3.Corner.Full"
-                tools:visibility="visible" />
-        </FrameLayout>
+            app:contentPadding="6dp"
+            app:shapeAppearanceOverlay="@style/ShapeAppearance.Material3.Corner.Full"
+            tools:visibility="visible" />
 
         <androidx.appcompat.widget.LinearLayoutCompat
             android:layout_width="0dp"