Skip to content

Commit e591341

Browse files
committed
feat: replace label elements with span for lead details to improve semantic structure
1 parent 5ab2248 commit e591341

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/routes/(app)/+layout.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
onclick={() => (drawerHidden = !drawerHidden)}
1212
class="fixed top-4 left-4 z-50 lg:hidden inline-flex items-center p-2 text-gray-500 rounded-lg hover:bg-gray-100 focus:outline-none focus:ring-2 focus:ring-gray-200 dark:text-gray-400 dark:hover:bg-gray-800 dark:focus:ring-gray-600 transition-colors bg-white dark:bg-gray-900 shadow-md border border-gray-200 dark:border-gray-700"
1313
class:hidden={!drawerHidden}
14+
aria-label="Open sidebar menu"
1415
>
1516
<svg class="w-6 h-6" fill="currentColor" viewBox="0 0 24 24">
1617
<path d="M3 12h18M3 6h18M3 18h18" stroke="currentColor" stroke-width="2" stroke-linecap="round"/>

src/routes/(app)/app/leads/[lead_id]/+page.svelte

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@
340340
<div class="space-y-2">
341341
<div class="flex items-center gap-2">
342342
<Target class="w-4 h-4 text-gray-400 dark:text-gray-500" />
343-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Lead Source</label>
343+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Lead Source</span>
344344
</div>
345345
<p class="text-sm text-gray-900 dark:text-gray-100 font-medium bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg">
346346
{getLeadSourceDisplay(lead.leadSource)}
@@ -353,7 +353,7 @@
353353
<div class="space-y-2">
354354
<div class="flex items-center gap-2">
355355
<Briefcase class="w-4 h-4 text-gray-400 dark:text-gray-500" />
356-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Industry</label>
356+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Industry</span>
357357
</div>
358358
<p class="text-sm text-gray-900 dark:text-gray-100 font-medium bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg capitalize">
359359
{lead.industry}
@@ -366,7 +366,7 @@
366366
<div class="space-y-2">
367367
<div class="flex items-center gap-2">
368368
<Award class="w-4 h-4 text-gray-400 dark:text-gray-500" />
369-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Rating</label>
369+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Rating</span>
370370
</div>
371371
<div class="flex items-center gap-2 bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg">
372372
{#each Array(parseInt(lead.rating) || 0) as _, i}
@@ -385,7 +385,7 @@
385385
<div class="space-y-2">
386386
<div class="flex items-center gap-2">
387387
<DollarSign class="w-4 h-4 text-gray-400 dark:text-gray-500" />
388-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Annual Revenue</label>
388+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Annual Revenue</span>
389389
</div>
390390
<p class="text-sm text-gray-900 dark:text-gray-100 font-medium bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg">
391391
${lead.annualRevenue.toLocaleString()}
@@ -397,7 +397,7 @@
397397
<div class="space-y-2">
398398
<div class="flex items-center gap-2">
399399
<User class="w-4 h-4 text-gray-400 dark:text-gray-500" />
400-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Lead Owner</label>
400+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Lead Owner</span>
401401
</div>
402402
<p class="text-sm text-gray-900 dark:text-gray-100 font-medium bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg">
403403
{lead.owner?.name || 'Unassigned'}
@@ -408,7 +408,7 @@
408408
<div class="space-y-2">
409409
<div class="flex items-center gap-2">
410410
<Calendar class="w-4 h-4 text-gray-400 dark:text-gray-500" />
411-
<label class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Created</label>
411+
<span class="text-xs font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Created</span>
412412
</div>
413413
<p class="text-sm text-gray-900 dark:text-gray-100 font-medium bg-gray-50 dark:bg-gray-700 px-3 py-2 rounded-lg">
414414
{formatDateShort(lead.createdAt)}
@@ -421,7 +421,7 @@
421421
<div class="mt-8 pt-6 border-t border-gray-200 dark:border-gray-700">
422422
<div class="flex items-center gap-2 mb-3">
423423
<Location class="w-5 h-5 text-gray-400 dark:text-gray-500" />
424-
<label class="text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Address</label>
424+
<span class="text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Address</span>
425425
</div>
426426
<div class="bg-gray-50 dark:bg-gray-700 p-4 rounded-xl">
427427
<p class="text-sm text-gray-900 dark:text-gray-100 whitespace-pre-line leading-relaxed">{lead.address}</p>
@@ -434,7 +434,7 @@
434434
<div class="mt-8 pt-6 border-t border-gray-200 dark:border-gray-700">
435435
<div class="flex items-center gap-2 mb-3">
436436
<MessageSquare class="w-5 h-5 text-gray-400 dark:text-gray-500" />
437-
<label class="text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Description</label>
437+
<span class="text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide">Description</span>
438438
</div>
439439
<div class="bg-gray-50 dark:bg-gray-700 p-4 rounded-xl">
440440
<div class="prose prose-sm max-w-none text-gray-700 dark:text-gray-300">

0 commit comments

Comments
 (0)