Skip to content

Max items feature #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Max items feature #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf3e70b
Merge pull request #1 from MhdSyrwan/master
langhard Apr 11, 2018
47059ba
Added maxItems feature.
langhard Apr 13, 2018
88edbc9
Show max items count (optional)
langhard Apr 13, 2018
5f959fe
Fixed duplicate declaration "maxItemsCount
langhard Apr 13, 2018
1c2b828
Fixed count issue and cleanup
langhard May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,18 @@ labelStyle: {
```

You can also pass `insertDividers` value as `true` or `false` to get the divider or not. Default value for `insertDividers` is true.

### Limit list items

There is a prop named `maxItems`:

```jsx
<EmbeddedArrayField source="links" maxItems={3}>
<UrlField source="url" />
<TextField source="context" />
<EmbeddedArrayField source="metadata" maxItems={5}>
<TextField source="name" />
<TextField source="value" />
</EmbeddedArrayField>
</EmbeddedArrayField>
```
10 changes: 9 additions & 1 deletion src/mui/input/EmbeddedArrayInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export class EmbeddedArrayInput extends Component {
labelContainerStyle: PropTypes.object,
labelStyle: PropTypes.object,
insertDividers: PropTypes.bool,
maxItems: PropTypes.number,
maxItemsCount: PropTypes.bool,
};

static defaultProps = {
Expand All @@ -86,6 +88,7 @@ export class EmbeddedArrayInput extends Component {
labelAdd: 'aor.input.embedded_array.add',
labelRemove: 'aor.input.embedded_array.remove',
insertDividers: true,
maxItemsCount: true,
actionsContainerStyle: {
clear: 'both',
margin: '1em',
Expand Down Expand Up @@ -182,8 +185,12 @@ export class EmbeddedArrayInput extends Component {
actionsContainerStyle,
innerContainerStyle,
insertDividers,
maxItems,
maxItemsCount,
} = this.props;
const createItem = () => items.push();
const isMaxItemsReached = () => {return (maxItems && maxItems === items.length) ? true : false};
const showMaxItemsCount = () => {return (maxItems && maxItemsCount) ? ' ('+items.length+'/'+maxItems+')' : '';} ;

return (
<div className="EmbeddedArrayInputContainer" style={style}>
Expand Down Expand Up @@ -212,10 +219,11 @@ export class EmbeddedArrayInput extends Component {
{allowAdd &&
!readOnly &&
!disabled &&
!isMaxItemsReached() &&
<FlatButton
primary
icon={<ContentAdd />}
label={translate(labelAdd, { _: 'Add' })}
label={translate(labelAdd, { _: 'Add' })+showMaxItemsCount()}
onClick={createItem}
/>}
</div>
Expand Down