Skip to content

Commit 3d5c37f

Browse files
Improve chip background colors (#3960)
Closes #3959
1 parent 23cb29c commit 3d5c37f

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/MaterialDesignThemes.Wpf/ThemeExtensions.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static partial void SetLightTheme(this Theme theme)
3434
theme.CheckBoxes.Disabled = BaseThemeColors.Neutral700;
3535
theme.CheckBoxes.UncheckedBorder = BaseThemeColors.Black100;
3636
theme.CheckBoxes.Off = BaseThemeColors.Black500;
37-
theme.Chips.Background = Color.FromArgb(0x12, 0x00, 0x00, 0x00);
37+
theme.Chips.Background = BaseThemeColors.Black50;
3838
theme.Chips.OutlineBorder = BaseThemeColors.Black100;
3939
theme.ColorZones.DarkBackground = BaseThemeColors.Neutral100;
4040
theme.ColorZones.DarkForeground = BaseThemeColors.Neutral900;
@@ -123,7 +123,7 @@ public static partial void SetDarkTheme(this Theme theme)
123123
theme.CheckBoxes.Disabled = BaseThemeColors.Neutral300;
124124
theme.CheckBoxes.UncheckedBorder = BaseThemeColors.White100;
125125
theme.CheckBoxes.Off = BaseThemeColors.White500;
126-
theme.Chips.Background = Color.FromArgb(0xFF, 0x2E, 0x3C, 0x43);
126+
theme.Chips.Background = BaseThemeColors.White50;
127127
theme.Chips.OutlineBorder = BaseThemeColors.White100;
128128
theme.ColorZones.DarkBackground = BaseThemeColors.Neutral100;
129129
theme.ColorZones.DarkForeground = BaseThemeColors.Neutral900;

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.Dark.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<colors:StaticResource x:Key="MaterialDesign.Brush.Card.Border" ResourceKey="Neutral500" />
1919
<colors:StaticResource x:Key="MaterialDesign.Brush.CheckBox.Disabled" ResourceKey="Neutral300" />
2020
<colors:StaticResource x:Key="MaterialDesign.Brush.CheckBox.UncheckedBorder" ResourceKey="White100" />
21-
<SolidColorBrush x:Key="MaterialDesign.Brush.Chip.Background" Color="#FF2E3C43" po:Freeze="True" />
21+
<colors:StaticResource x:Key="MaterialDesign.Brush.Chip.Background" ResourceKey="White50" />
2222
<colors:StaticResource x:Key="MaterialDesign.Brush.Chip.OutlineBorder" ResourceKey="White100" />
2323
<colors:StaticResource x:Key="MaterialDesign.Brush.ColorZone.DarkBackground" ResourceKey="Neutral100" />
2424
<colors:StaticResource x:Key="MaterialDesign.Brush.ColorZone.DarkForeground" ResourceKey="Neutral900" />

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.Light.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<colors:StaticResource x:Key="MaterialDesign.Brush.Card.Border" ResourceKey="Neutral700" />
1919
<colors:StaticResource x:Key="MaterialDesign.Brush.CheckBox.Disabled" ResourceKey="Neutral700" />
2020
<colors:StaticResource x:Key="MaterialDesign.Brush.CheckBox.UncheckedBorder" ResourceKey="Black100" />
21-
<SolidColorBrush x:Key="MaterialDesign.Brush.Chip.Background" Color="#12000000" po:Freeze="True" />
21+
<colors:StaticResource x:Key="MaterialDesign.Brush.Chip.Background" ResourceKey="Black50" />
2222
<colors:StaticResource x:Key="MaterialDesign.Brush.Chip.OutlineBorder" ResourceKey="Black100" />
2323
<colors:StaticResource x:Key="MaterialDesign.Brush.ColorZone.DarkBackground" ResourceKey="Neutral100" />
2424
<colors:StaticResource x:Key="MaterialDesign.Brush.ColorZone.DarkForeground" ResourceKey="Neutral900" />

src/MaterialDesignToolkit.ResourceGeneration/ThemeColors.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@
160160
{
161161
"name": "MaterialDesign.Brush.Chip.Background",
162162
"themeValues": {
163-
"light": "#12000000",
164-
"dark": "#FF2E3C43"
163+
"light": "Black50",
164+
"dark": "White50"
165165
},
166166
"alternateKeys": [],
167167
"obsoleteKeys": [

0 commit comments

Comments
 (0)