Skip to content

Commit 655e18f

Browse files
committed
fixes
1 parent df289a5 commit 655e18f

File tree

6 files changed

+9
-16
lines changed

6 files changed

+9
-16
lines changed

src/Builders/SpatialBuilder.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace MatanYadaev\EloquentSpatial\Builders;
44

5-
use Illuminate\Database\Connection;
65
use Illuminate\Database\Eloquent\Builder;
76
use Illuminate\Database\Query\Expression;
87
use MatanYadaev\EloquentSpatial\Objects\Geometry;
@@ -20,7 +19,7 @@ public function withDistance(string $column, Geometry | string $geometryOrColumn
2019
return $this->selectRaw("ST_DISTANCE(`{$column}`, {$geometryOrColumn}) AS {$as}");
2120
}
2221

23-
public function whereDistance(string $column, Geometry | string $geometryOrColumn, string $operator, int|float $distance): self
22+
public function whereDistance(string $column, Geometry | string $geometryOrColumn, string $operator, int | float $distance): self
2423
{
2524
$geometryOrColumn = $this->toExpression($geometryOrColumn);
2625

@@ -51,7 +50,7 @@ public function withDistanceSphere(string $column, Geometry | string $geometryOr
5150
return $this;
5251
}
5352

54-
public function whereDistanceSphere(string $column, Geometry | string $geometryOrColumn, string $operator, int|float $distance): self
53+
public function whereDistanceSphere(string $column, Geometry | string $geometryOrColumn, string $operator, int | float $distance): self
5554
{
5655
$geometryOrColumn = $this->toExpression($geometryOrColumn);
5756

src/Factory.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Collection as geoPHPGeometryCollection;
66
use Geometry as geoPHPGeometry;
77
use geoPHP;
8-
use Illuminate\Support\Collection;
98
use LineString as geoPHPLineString;
109
use MatanYadaev\EloquentSpatial\Objects\Geometry;
1110
use MatanYadaev\EloquentSpatial\Objects\GeometryCollection;
@@ -25,17 +24,14 @@ class Factory
2524
{
2625
public static function parse(string $value): Geometry
2726
{
28-
if (is_json($value)) {
29-
/** @var geoPHPGeometry $geoPHPGeometry */
30-
$geoPHPGeometry = geoPHP::load($value);
31-
} else {
27+
if (! is_json($value)) {
3228
// MySQL adds 4 NULL bytes at the start of the WKB
3329
$value = substr($value, 4);
34-
35-
/** @var geoPHPGeometry $geoPHPGeometry */
36-
$geoPHPGeometry = geoPHP::load($value);
3730
}
3831

32+
/** @var geoPHPGeometry $geoPHPGeometry */
33+
$geoPHPGeometry = geoPHP::load($value);
34+
3935
return self::create($geoPHPGeometry);
4036
}
4137

@@ -63,6 +59,7 @@ protected static function create(geoPHPGeometry $geometry): Geometry
6359
if ($className === geoPHPMultiPolygon::class) {
6460
return self::createMultiPolygon($components);
6561
}
62+
6663
return self::createGeometryCollection($components);
6764
}
6865
if ($geometry instanceof geoPHPPoint) {

tests/Builders/SpatialBuilderTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Illuminate\Foundation\Testing\DatabaseMigrations;
66
use MatanYadaev\EloquentSpatial\Objects\MultiPolygon;
77
use MatanYadaev\EloquentSpatial\Objects\Point;
8-
use MatanYadaev\EloquentSpatial\Objects\Polygon;
98
use MatanYadaev\EloquentSpatial\Tests\TestCase;
109
use MatanYadaev\EloquentSpatial\Tests\TestModels\TestPlace;
1110

tests/Objects/GeometryCollectionTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Illuminate\Foundation\Testing\DatabaseMigrations;
66
use MatanYadaev\EloquentSpatial\Objects\GeometryCollection;
77
use MatanYadaev\EloquentSpatial\Objects\LineString;
8-
use MatanYadaev\EloquentSpatial\Objects\MultiPolygon;
98
use MatanYadaev\EloquentSpatial\Objects\Point;
109
use MatanYadaev\EloquentSpatial\Objects\Polygon;
1110
use MatanYadaev\EloquentSpatial\Tests\TestCase;

tests/Objects/MultiPointTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace MatanYadaev\EloquentSpatial\Tests\Objects;
44

55
use Illuminate\Foundation\Testing\DatabaseMigrations;
6-
use MatanYadaev\EloquentSpatial\Objects\LineString;
76
use MatanYadaev\EloquentSpatial\Objects\MultiPoint;
87
use MatanYadaev\EloquentSpatial\Objects\Point;
98
use MatanYadaev\EloquentSpatial\Tests\TestCase;

tests/Objects/MultiPolygonTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function it_stores_multi_polygon()
2727
new Point(23.3, 55.7),
2828
new Point(23.1, 55.5),
2929
]),
30-
])
30+
]),
3131
]),
3232
])->fresh();
3333

@@ -86,7 +86,7 @@ public function it_generates_multi_polygon_geo_json()
8686
new Point(23.3, 55.7),
8787
new Point(23.1, 55.5),
8888
]),
89-
])
89+
]),
9090
]);
9191

9292
$this->assertEquals('{"type":"MultiPolygon","coordinates":[[[[55.5,23.1],[55.6,23.2],[55.7,23.3],[55.5,23.1]]]]}', $multiPolygon->toJson());

0 commit comments

Comments
 (0)