Upgrade project for CMake 4

Author: MartinHelmut

.github/workflows/release.yml

@@ -2,9 +2,9 @@ name: Release
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 env:
   BUILD_TYPE: Release
@@ -13,15 +13,15 @@ jobs:
   build:
     strategy:
       matrix:
-        os: [ macos-14, ubuntu-latest, windows-latest ]
+        os: [macos-14, ubuntu-latest, windows-latest]
 
     runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v4
 
       - name: Configure CMake
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DWARNINGS_AS_ERRORS=FALSE
 
       - name: Build
         run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

.gitignore

@@ -1,6 +1,7 @@
 # Application build output
 build/
 distribution/
+.cache/
 
 # Created by CPack when executing tests.
 Testing/
@@ -14,3 +15,4 @@ profile.json
 
 # User defined CMake preset file.
 CMakeUserPresets.json
+*.sublime-workspace

CMakePresets.json

@@ -16,7 +16,8 @@
       "generator": "Ninja",
       "binaryDir": "build/release",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Release"
+        "CMAKE_BUILD_TYPE": "Release",
+        "WARNINGS_AS_ERRORS": "FALSE"
       }
     },
     {
@@ -41,7 +42,8 @@
       "binaryDir": "build/xcode-release",
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Release",
-        "CMAKE_OSX_ARCHITECTURES": "x86_64;arm64"
+        "CMAKE_OSX_ARCHITECTURES": "x86_64;arm64",
+        "WARNINGS_AS_ERRORS": "FALSE"
       },
       "condition": {
         "type": "equals",
@@ -62,9 +64,7 @@
       "displayName": "Build Release",
       "configurePreset": "release",
       "configuration": "Release",
-      "targets": [
-        "App"
-      ]
+      "targets": ["App"]
     },
     {
       "name": "xcode-debug",
@@ -82,9 +82,7 @@
       "displayName": "Build Release (Xcode)",
       "configurePreset": "xcode-release",
       "configuration": "Release",
-      "targets": [
-        "App"
-      ],
+      "targets": ["App"],
       "condition": {
         "type": "equals",
         "lhs": "${hostSystemName}",
@@ -97,17 +95,13 @@
       "name": "release",
       "displayName": "Distribute Release",
       "configurePreset": "release",
-      "configurations": [
-        "Release"
-      ]
+      "configurations": ["Release"]
     },
     {
       "name": "xcode-release",
       "displayName": "Distribute Release (Xcode)",
       "configurePreset": "xcode-release",
-      "configurations": [
-        "Release"
-      ],
+      "configurations": ["Release"],
       "condition": {
         "type": "equals",
         "lhs": "${hostSystemName}",

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2024 <copyright holders>
+Copyright (c) 2025 <copyright holders>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

cmake/CompilerWarnings.cmake

@@ -2,7 +2,6 @@
 
 function(set_project_warnings project_name)
   option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" TRUE)
-  message(STATUS "Treat compiler warnings as errors")
 
   set(MSVC_WARNINGS
     /W4 # Baseline reasonable warnings
@@ -59,6 +58,7 @@ function(set_project_warnings project_name)
     )
 
   if (WARNINGS_AS_ERRORS)
+    message(STATUS "Treat compiler warnings as errors")
     set(CLANG_WARNINGS ${CLANG_WARNINGS} -Werror)
     set(MSVC_WARNINGS ${MSVC_WARNINGS} /WX)
   endif ()

docs/Profiling.md

@@ -68,8 +68,7 @@ int Application::run() {
 
 ## Show results
 
-The resulting JSON file uses
-the [Trace Event Format](https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview). Any
+The resulting JSON file (`profile.json`) uses the [Trace Event Format](https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview). Any
 tool that can read this format can visualize the profiler data. For example the web
 tool [Perfetto](https://ui.perfetto.dev/) or Chromes built in [chrome://tracing](chrome://tracing). Just drag&drop the
 generated profiler JSON file onto the tool to load it.
@@ -78,6 +77,6 @@ This is roughly how this looks like on Chrome.
 
 ![chrome-trace.png](assets/chrome-trace.png)
 
-***
+---
 
 Next up: [Logging](Logging.md)

packaging/CMakeLists.txt

@@ -44,6 +44,7 @@ set(CPACK_NSIS_MUI_UNWELCOMEFINISHPAGE_BITMAP ${CMAKE_CURRENT_LIST_DIR}/nsis\\\\
 
 # Linux DEB settings
 set(CPACK_DEBIAN_FILE_NAME DEB-DEFAULT)
+set(CPACK_DEBIAN_PACKAGE_DEPENDS "libsdl3-3.0-0")
 # Section list: https://packages.debian.org/unstable/
 set(CPACK_DEBIAN_PACKAGE_SECTION Miscellaneous)
 set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Maintainer Name")

src/core/CMakeLists.txt

@@ -7,7 +7,7 @@ add_library(${NAME} STATIC
   Core/Application.cpp Core/Application.hpp
   Core/Window.cpp Core/Window.hpp
   Core/DPIHandler.cpp Core/DPIHandler.hpp
-  Core/Resources.hpp)
+  Core/Resources.hpp Core/Resources.cpp)
 
 # Define set of OS specific files to include
 if (CMAKE_SYSTEM_NAME STREQUAL "Windows")

src/core/Core/Application.cpp

@@ -15,8 +15,7 @@ namespace App {
 Application::Application(const std::string& title) {
   APP_PROFILE_FUNCTION();
 
-  const unsigned int init_flags{SDL_INIT_VIDEO | SDL_INIT_TIMER | SDL_INIT_GAMEPAD};
-  if (!SDL_Init(init_flags)) {
+  if (!SDL_Init(SDL_INIT_VIDEO | SDL_INIT_GAMEPAD)) {
     APP_ERROR("Error on SDL_Init(): %s\n", SDL_GetError());
     m_exit_status = ExitStatus::FAILURE;
   }

src/core/Core/Resources.cpp

@@ -0,0 +1,18 @@
+#include "Core/Resources.hpp"
+
+#include <sys/stat.h>
+
+#include <filesystem>
+
+#include "Core/Debug/Instrumentor.hpp"
+
+namespace App {
+
+bool Resources::exists(const std::filesystem::path& pathname) {
+  APP_PROFILE_FUNCTION();
+
+  struct stat buffer;
+  return (stat(pathname.generic_string().c_str(), &buffer) == 0);
+}
+
+}  // namespace App