Commit e943ece
committed
Remove
Since Rust 1.82 the minimum Android API level is 21. In
`backtrace`, this warranted the removal of the API version check via
`__ANDROID_API__` in rust-lang/backtrace-rs#656
since it is now always known to be >=21. When `findshlibs` bumps its
MSRV the same could be done.
This change is sparked by a long search for why backtraces always had
`<unknown>` symbols on Android - and when solving that by upgrading Rust
(for `std::backtrace`) or our `backtrace` dependency, why Sentry reports
did not record what images/libraries were loaded at which offsets to
resolve stack addresses back to function symbols. It turned out that
the `xbuild` build tool never set `__ANDROID_API__` (by not telling
`clang` about the target API level via the triple) which would cause
this code to never set `feature = "dl_iterate_phdr"` to search for
libraries on Android: rust-mobile/xbuild#209build.rs for Android when assuming API level is always >=211 parent 42f4833 commit e943ece
4 files changed
+5
-61
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | 16 | | |
21 | 17 | | |
22 | 18 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
| 103 | + | |
107 | 104 | | |
108 | 105 | | |
109 | 106 | | |
110 | 107 | | |
111 | 108 | | |
112 | 109 | | |
113 | 110 | | |
114 | | - | |
115 | 111 | | |
116 | 112 | | |
117 | 113 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
| 114 | + | |
122 | 115 | | |
123 | 116 | | |
124 | 117 | | |
| |||
131 | 124 | | |
132 | 125 | | |
133 | 126 | | |
134 | | - | |
| 127 | + | |
135 | 128 | | |
136 | 129 | | |
137 | 130 | | |
| |||
145 | 138 | | |
146 | 139 | | |
147 | 140 | | |
148 | | - | |
| 141 | + | |
149 | 142 | | |
150 | 143 | | |
151 | 144 | | |
| |||
0 commit comments