Skip to content

Commit 91401d2

Browse files
prushforthJacky0299prushfor
authored
Fix context menu tabbing (#844)
* Tab compatible with Arrow key * comment * Refactor constants to have somewhat meaningful names Rename some methods to be more related to what they do * Restore catch-all logic that relates to layer context menu, but is obscure and complicated. Use KeyboardEvent.code for its case-insensitive mnemonics. * Fix Firefox issue where Shift+F10 would always display the context menu near the origin of the map container. * Add tests for tab / shift+tab keyboard navigation of context menus * Support Shift+Tab equivalent to ArrowUp in map context menu * Support Shift+Tab equivalent to ArrowUp in layer context menu * Prevent default on Arrow keys to prevent unwanted document scrolling * Fix error when Shift+F10 / contextmenu pressed on features * Fix firefox fix * Simplify odd logic - let's see if tests pass... * Test that error doesn't happen with Shift+F10 on features * Test arrow keys on context menu don't trigger page scroll --------- Co-authored-by: Jacky0299 <jackyissuperman@gmail.com> Co-authored-by: prushfor <prushfor@L-BSC-A146390.nrn.nrcan.gc.ca>
1 parent 4b15fa4 commit 91401d2

10 files changed

+540
-135
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)