Report error from opener in bootstrap

dtolnay · dtolnay · commit 07b1de4e9a4a · 2020-05-22T09:51:46.000-07:00
On my machine, an error looks like:

    Finished release [optimized] target(s) in 0.29s
    Opening doc /git/rust/build/x86_64-unknown-linux-gnu/doc/std/index.html
    command 'xdg-open (internal)' did not execute successfully; exit code: 4
    command stderr:
    gio: file:///git/rust/build/x86_64-unknown-linux-gnu/doc/std/index.html: Error when getting information for file “/git/rust/build/x86_64-unknown-linux-gnu/doc/std/index.html”: No such file or directory

    Build completed successfully in 0:00:08
diff --git a/src/bootstrap/doc.rs b/src/bootstrap/doc.rs
@@ -76,10 +76,10 @@ fn open(builder: &Builder<'_>, path: impl AsRef<Path>) {
     }
 
     let path = path.as_ref();
-    builder.info(&format!("Opening doc {}", path.to_string_lossy()));
-
-    // ignore error
-    let _ = opener::open(path);
+    builder.info(&format!("Opening doc {}", path.display()));
+    if let Err(err) = opener::open(path) {
+        builder.info(&format!("{}\n", err));
+    }
 }
 
 // "src/libstd" -> ["src", "libstd"]

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,10 @@ fn open(builder: &Builder<'_>, path: impl AsRef<Path>) {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`let path = path.as_ref();`
`79`		`- builder.info(&format!("Opening doc {}", path.to_string_lossy()));`
`80`		`-`
`81`		`- // ignore error`
`82`		`- let _ = opener::open(path);`
	`79`	`+ builder.info(&format!("Opening doc {}", path.display()));`
	`80`	`+ if let Err(err) = opener::open(path) {`
	`81`	`+ builder.info(&format!("{}\n", err));`
	`82`	`+ }`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`// "src/libstd" -> ["src", "libstd"]`