Add comments to specs

Author: kbrock

lib/active_record/virtual_attributes/virtual_delegates.rb

@@ -81,6 +81,7 @@ def define_delegate(method_name, method, to: nil, allow_nil: nil, default: nil)
           # On the other hand it could be that the target has side-effects,
           # whereas conceptually, from the user point of view, the delegator should
           # be doing one call.
+          # NOTE: This is based upon ActiveSupport 6.0 delegate.rb, but we added has_attribute? and default
           if allow_nil
             method_def = <<-METHOD
               def #{method_name}(#{definition})

spec/db/models.rb

@@ -1,4 +1,4 @@
-class VirtualTotalTestBase < ActiveRecord::Base  # rubocop:disable Rails/ApplicationRecord
+class VirtualTotalTestBase < ActiveRecord::Base # rubocop:disable Rails/ApplicationRecord
   self.abstract_class = true
 
   include VirtualFields

spec/support/with_test_class.rb

@@ -13,7 +13,7 @@
 #
 RSpec.shared_context 'with test_class', :with_test_class do
   before do
-    class TestClassBase < ActiveRecord::Base
+    class TestClassBase < ActiveRecord::Base # rubocop:disable Rails/ApplicationRecord
       self.abstract_class = true
 
       include VirtualFields

spec/virtual_attributes_spec.rb

@@ -208,7 +208,7 @@
     end
 
     context "add_virtual_reflection integration" do
-      it "with invalid parameters" do
+      it "expects an association name" do
         expect { TestClass.virtual_has_one }.to raise_error(ArgumentError)
       end
 
@@ -218,17 +218,17 @@
         expect(TestClass.virtual_reflection(:vref1).name).to eq(:vref1)
       end
 
-      it("with has_one macro") do
+      it "with has_one macro" do
         TestClass.virtual_has_one(:vref1)
         expect(TestClass.virtual_reflection(:vref1).macro).to eq(:has_one)
       end
 
-      it("with has_many macro") do
+      it "with has_many macro" do
         TestClass.virtual_has_many(:vref1)
         expect(TestClass.virtual_reflection(:vref1).macro).to eq(:has_many)
       end
 
-      it("with belongs_to macro") do
+      it "with belongs_to macro" do
         TestClass.virtual_belongs_to(:vref1)
         expect(TestClass.virtual_reflection(:vref1).macro).to eq(:belongs_to)
       end