Improve quality tools + unit test

Author: MacFJA

.gitattributes

@@ -25,4 +25,5 @@ Makefile  text
 /Makefile         export-ignore
 /phpmd.xml        export-ignore
 /phpstan.neon     export-ignore
+/phpunit.xml      export-ignore
 /psalm.xml        export-ignore

.gitignore

@@ -4,3 +4,4 @@
 
 /.php_cs.cache
 /.phpunit.cache/
+/.phpunit.result.cache

composer.json

@@ -21,6 +21,7 @@
         "sgh/comparable": "^1.1"
     },
     "require-dev": {
+        "enlightn/security-checker": "^1.5",
         "ergebnis/composer-normalize": "^2.13",
         "friendsofphp/php-cs-fixer": "^2.16",
         "insolita/unused-scanner": "^2.2",
@@ -31,7 +32,6 @@
         "phpunit/phpunit": "^9.5",
         "rskuipers/php-assumptions": "^0.8.0",
         "sebastian/phpcpd": "^6.0",
-        "sensiolabs/security-checker": "^6.0",
         "vimeo/psalm": "^4.2"
     },
     "autoload": {

phpunit.xml

@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.5/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         cacheResultFile=".phpunit.cache/test-results"
+         executionOrder="depends,defects"
+         forceCoversAnnotation="true"
+         beStrictAboutCoversAnnotation="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutTodoAnnotatedTests="true"
+         stopOnFailure="true"
+         stopOnError="true"
+         stopOnDefect="true"
+         failOnEmptyTestSuite="true"
+         stopOnWarning="true"
+         beStrictAboutTestsThatDoNotTestAnything="true"
+         beStrictAboutResourceUsageDuringSmallTests="true"
+         beStrictAboutChangesToGlobalState="true"
+         cacheResult="true"
+         convertDeprecationsToExceptions="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         failOnIncomplete="false"
+         failOnSkipped="false"
+         stopOnIncomplete="false"
+         stopOnRisky="false"
+         stopOnSkipped="false"
+         failOnRisky="true"
+         failOnWarning="true"
+         verbose="true">
+    <testsuites>
+        <testsuite name="default">
+            <directory suffix="Test.php">tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <coverage cacheDirectory=".phpunit.cache/code-coverage"
+              processUncoveredFiles="true">
+        <include>
+            <directory suffix=".php">src</directory>
+        </include>
+    </coverage>
+</phpunit>

tests/Search/QueryBuilder/NumericFacetTest.php

@@ -1,12 +1,35 @@
 <?php
 
+declare(strict_types=1);
+
+/*
+ * Copyright MacFJA
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated
+ * documentation files (the "Software"), to deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
+ * WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+ * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
 namespace Tests\MacFJA\RediSearch\Search\QueryBuilder;
 
 use MacFJA\RediSearch\Search\QueryBuilder\NumericFacet;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @coversDefaultClass \MacFJA\RediSearch\Search\QueryBuilder\NumericFacet
+ * @covers ::render
+ *
+ * @uses \MacFJA\RediSearch\Helper\EscapeHelper
+ * @uses \MacFJA\RediSearch\Search\QueryBuilder\NumericFacet
  *
  * @see: https://oss.redislabs.com/redisearch/Query_Syntax/#mapping_common_sql_predicates_to_redisearch
  * WHERE num BETWEEN 10 AND 20	    @num:[10 20]
@@ -24,7 +47,7 @@ class NumericFacetTest extends TestCase
     public function testGreaterThan()
     {
         $facet = NumericFacet::greaterThan('num', 10);
-        $this->assertSame('@num:[(10 +inf]', $facet->render());
+        self::assertSame('@num:[(10 +inf]', $facet->render());
     }
 
     /**
@@ -33,7 +56,7 @@ public function testGreaterThan()
     public function testGreaterThanOrEquals()
     {
         $facet = NumericFacet::greaterThanOrEquals('num', 10);
-        $this->assertSame('@num:[10 +inf]', $facet->render());
+        self::assertSame('@num:[10 +inf]', $facet->render());
     }
 
     /**
@@ -42,7 +65,7 @@ public function testGreaterThanOrEquals()
     public function testLessThan()
     {
         $facet = NumericFacet::lessThan('num', 10);
-        $this->assertSame('@num:[-inf (10]', $facet->render());
+        self::assertSame('@num:[-inf (10]', $facet->render());
     }
 
     /**
@@ -51,7 +74,7 @@ public function testLessThan()
     public function testLessThanOrEquals()
     {
         $facet = NumericFacet::lessThanOrEquals('num', 10);
-        $this->assertSame('@num:[-inf 10]', $facet->render());
+        self::assertSame('@num:[-inf 10]', $facet->render());
     }
 
     /**
@@ -60,6 +83,6 @@ public function testLessThanOrEquals()
     public function testEqualsTo()
     {
         $facet = NumericFacet::equalsTo('num', 10);
-        $this->assertSame('@num:[10 10]', $facet->render());
+        self::assertSame('@num:[10 10]', $facet->render());
     }
 }