Update phpstan

Author: MacFJA

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - `APPLY` option of Aggregate command is now dependent of the last inserted option (if the option have a meaning for `APPLY`)
+- (dev) Update `phpstan` (from `0.12` to `1.2`)
 
 ### Fixed
 

composer.json

@@ -32,7 +32,7 @@
         "insolita/unused-scanner": "^2.3",
         "php-parallel-lint/php-parallel-lint": "^1.3",
         "phpmd/phpmd": "^2.10",
-        "phpstan/phpstan": "^0.12.92",
+        "phpstan/phpstan": "^1.2.0",
         "phpunit/phpunit": "^8.5 || ^9.3",
         "predis/predis": "^1.1",
         "ptrofimov/tinyredisclient": "^1.1",

phpstan.neon

@@ -10,6 +10,7 @@ parameters:
         - '#Method MacFJA\\RediSearch\\Redis\\Command\\\w+::getLanguageOptions\(\) should return#'
         - '#uses generic trait MacFJA\\RediSearch\\Redis\\Command\\Option\\DecoratedOptionTrait but does not specify its types: T#'
         - '#Call to an undefined method MacFJA\\RediSearch\\Redis\\Command\\Option\\CustomValidatorOption::setValue\(\).#'
+        - '#Method MacFJA\\RediSearch\\tests\\Redis.+::dataProvider\(\) return type has no value type specified in iterable type (array|Generator).#'
         -
             message: '#Call to an undefined method MacFJA\\RediSearch\\Redis\\Command\\Option\\CommandOption::set\w+\(\).#'
             path: src/Redis/Command/Option/GroupedOption.php

src/Redis/Command/AggregateCommand/ReduceOption.php

@@ -60,7 +60,7 @@ public function isValid(): bool
     }
 
     /**
-     * @return array<string,null|array|string>
+     * @return array<string,null|array<float|int|string>|string>
      */
     public function getOptionData()
     {

tests/Redis/Command/Option/BaseOptionTestTrait.php

@@ -54,8 +54,5 @@ public function testGetOptionData(CommandOption $inputOption, $expected): void
         self::assertEquals($expected, $inputOption->getOptionData());
     }
 
-    /**
-     * @return Generator<array>
-     */
     abstract public function dataProvider(string $testName): Generator;
 }

tests/Redis/Command/Option/CustomValidatorOptionTest.php

@@ -61,9 +61,6 @@ public function testShorthands(): void
         static::assertFalse($invalidList->isValid());
     }
 
-    /**
-     * @return Generator<array>
-     */
     public function dataProvider(string $testName): Generator
     {
         $invalidMinLengthOption = new CustomValidatorOption(new NamelessOption('foo'), new Length(4));

tests/Redis/Command/Option/FlagOptionTest.php

@@ -58,9 +58,6 @@ public function testGetName(): void
         static::assertEquals('BAR', $option->getName());
     }
 
-    /**
-     * @return Generator<array>
-     */
     public function dataProvider(string $testName): Generator
     {
         $defaultValueFlag = new FlagOption('FOO');

tests/Redis/Command/Option/GroupedOptionTest.php

@@ -122,9 +122,6 @@ public function testSetLockOptionData(): void
         $option->setDataOfOption('lock', 'bar');
     }
 
-    /**
-     * @return Generator<array>
-     */
     public function dataProvider(string $testName): Generator
     {
         $emptyGroup = new GroupedOption([], []);

tests/Redis/Command/Option/NamedOptionTest.php

@@ -57,9 +57,6 @@ public function testGetName(): void
         static::assertEquals('BAR', $option->getName());
     }
 
-    /**
-     * @return Generator<array>
-     */
     public function dataProvider(string $testName): Generator
     {
         $defaultValueOption = new NamedOption('FOO');

tests/Redis/Command/Option/NamelessOptionTest.php

@@ -48,9 +48,6 @@ public function testGetSetValue(): void
         static::assertEquals(10, $option->getValue());
     }
 
-    /**
-     * @return Generator<array>
-     */
     public function dataProvider(string $testName): Generator
     {
         $defaultValueOption = new NamelessOption();