[UPDATE] Working coin precision system

* [ADDED] New option to coin class to change coin value precision
* [UPDATE] SQL Transactions table from double to decimal(50,30)
* [REMOVED] Admin setting for coin value precision
* [UPDATE] JS files to honor coin precision

Author: MPOS123

cronjobs/pplns_payout.php

@@ -39,8 +39,8 @@
 }
 
 // Fetch precision
-$precision = $setting->getValue('system_coin_precision', 12);
-$table_precision = $setting->getValue('system_coin_precision', 12) + 3;
+$precision = $coin->getCoinValuePrevision();
+$table_precision = $coin->getCoinValuePrevision() + 3;
 
 $log->logDebug('Starting PPLNS payout process');
 $count = 0;

cronjobs/pps_payout.php

@@ -89,8 +89,8 @@
 
 if (!empty($aAccountShares)) {
   // Runtime information for this payout
-  $precision = $setting->getValue('system_coin_precision', 12);
-  $table_precision = $setting->getValue('system_coin_precision', 12) + 3;
+  $precision = $coin->getCoinValuePrevision();
+  $table_precision = $coin->getCoinValuePrevision() + 3;
   $log->logInfo('Runtime information for this payout');
   $strLogMask = "| %-15.15s | %15.15s | %15.15s | %${table_precision}.${table_precision}s | %3.3s |";
   $log->logInfo(sprintf($strLogMask, 'PPS reward type', 'Reward Base', 'Difficulty', 'PPS Value', 'Precision'));

cronjobs/proportional_payout.php

@@ -39,8 +39,8 @@
 }
 
 // Fetch precision
-$precision = $setting->getValue('system_coin_precision', 12);
-$table_precision = $setting->getValue('system_coin_precision', 12) + 3;
+$precision = $coin->getCoinValuePrevision();
+$table_precision = $coin->getCoinValuePrevision() + 3;
 
 $count = 0;
 // Table header for account shares

include/classes/coins/coin_base.class.php

@@ -15,13 +15,23 @@ class CoinBase extends Base {
   // Our coins share difficulty precision
   protected $share_difficulty_precision = 0;
 
+  // Our coin value precision, mostly used on frontend
+  protected $coin_value_precision = 8;
+
   /**
    * Read our target bits
    **/
   public function getTargetBits() {
     return $this->target_bits;
   }
 
+  /**
+   * Read our coin value precision
+   **/
+  public function getCoinValuePrevision() {
+    return $this->coin_value_precision;
+  }
+
   /**
    * Read our share difficulty precision
    **/

include/classes/coins/coin_sha256d.class.php

@@ -8,6 +8,7 @@
  **/
 class Coin extends CoinBase {
   protected $target_bits = 32;
+  protected $coin_value_precision = 20;
 }
 
 ?>

include/classes/transaction.class.php

@@ -16,7 +16,7 @@ class Transaction extends Base {
    * @return bool
    **/
   public function addTransaction($account_id, $amount, $type='Credit', $block_id=NULL, $coin_address=NULL, $txid=NULL) {
-    $amount = number_format($amount, $this->setting->getValue('system_coin_precision', 12), '.', '');
+    $amount = number_format($amount, $this->coin->getCoinValuePrevision(), '.', '');
     $stmt = $this->mysqli->prepare("INSERT INTO $this->table (account_id, amount, block_id, type, coin_address, txid) VALUES (?, ?, ?, ?, ?, ?)");
     if ($this->checkStmt($stmt) && $stmt->bind_param("isisss", $account_id, $amount, $block_id, $type, $coin_address, $txid) && $stmt->execute()) {
       $this->insert_id = $stmt->insert_id;
@@ -480,6 +480,7 @@ public function getMPQueue($limit=250) {
 $transaction->setNotification($notification);
 $transaction->setSetting($setting);
 $transaction->setDebug($debug);
+$transaction->setCoin($coin);
 $transaction->setCoinAddress($coin_address);
 $transaction->setMysql($mysqli);
 $transaction->setConfig($config);

include/config/admin_settings.inc.php

@@ -308,13 +308,6 @@
   'name' => 'system_error_email', 'value' => $setting->getValue('system_error_email'),
   'tooltip' => 'The email address for system errors notifications, like cronjobs failures.'
 );
-$aSettings['system'][] = array(
-  'display' => 'Coin Precision', 'type' => 'text',
-  'size' => 5,
-  'default' => '12',
-  'name' => 'system_coin_precision', 'value' => $setting->getValue('system_coin_precision'),
-  'tooltip' => 'How do we round any coin values throughout MPOS. Defaults to 12 digits.'
-);
 $aSettings['system'][] = array(
   'display' => 'Date format string', 'type' => 'text',
   'size' => 25,

include/pages/dashboard.inc.php

@@ -49,7 +49,7 @@
   }
 
   // Make it available in Smarty
-  $smarty->assign('PRECISION', $setting->getValue('system_coin_precision', 12));
+  $smarty->assign('PRECISION', $coin->getCoinValuePrevision());
   $smarty->assign('BLOCKSFOUND', $aLastBlocks);
   $smarty->assign('DISABLED_DASHBOARD', $setting->getValue('disable_dashboard'));
   $smarty->assign('DISABLED_DASHBOARD_API', $setting->getValue('disable_dashboard_api'));

include/smarty_globals.inc.php

@@ -177,7 +177,7 @@
   case 'pps':
     $aGlobal['userdata']['pps']['unpaidshares'] = $statistics->getUserUnpaidPPSShares($_SESSION['USERDATA']['username'], $_SESSION['USERDATA']['id'], $setting->getValue('pps_last_share_id'));
     // We use coin precision + 8 to display PPS value
-    $aGlobal['ppsvalue'] = number_format($statistics->getPPSValue(), $setting->getValue('system_coin_precision', 12) + 8);
+    $aGlobal['ppsvalue'] = number_format($statistics->getPPSValue(), $coin->getCoinValuePrevision() + 8);
     $aGlobal['poolppsvalue'] = $aGlobal['ppsvalue'] * pow(2, $config['difficulty'] - 16);
     $aGlobal['userdata']['estimates'] = $statistics->getUserEstimates($aGlobal['userdata']['sharerate'], $aGlobal['userdata']['sharedifficulty'], $aGlobal['userdata']['donate_percent'], $aGlobal['userdata']['no_fees'], $aGlobal['ppsvalue']);
     break;

include/version.inc.php

@@ -2,7 +2,7 @@
 $defflip = (!cfip()) ? exit(header('HTTP/1.1 401 Unauthorized')) : 1;
 
 define('MPOS_VERSION', '0.0.4');
-define('DB_VERSION', '0.0.12');
+define('DB_VERSION', '0.0.13');
 define('CONFIG_VERSION', '0.0.8');
 define('HASH_VERSION', 1);