Address code review feedback

** Why are these changes being introduced:

* Rather than simply replacing geopoint with geoshape, we are going to
  keep geopoint in the code, but mark it as deprecated. This is the
  recommended workflow for making changes in GraphQL (which we are
  following here to reinforce the practice, even though this particular
  field has never been populated)

** How does this address that need:

* This brings back the geopoint field in the LocationType definition,
  but markes it deprecated in the schema.

* We add a method to the Location type that populates the geopoint
  field with the contents of the geoshape field. Ironically, this is
  likely the first time that the geopoint field has been able to respond
  with any values at all.

* We also update the test to include reference to this now-deprecated
  field.

** Document any side effects to this change:

* Is it a side effect to be, effectively, adding content to the geopoint
  field only as we mark it deprecated?

Author: matt-bernhardt

app/graphql/types/record_type.rb

@@ -108,9 +108,14 @@ class AlternateTitleType < Types::BaseObject
 
   # Warning: related_place was supposed to be an array but was incorrectly a string in graphql for v1
   class LocationType < Types::BaseObject
+    field :geopoint, String, deprecation_reason: 'Use `geoshape`'
     field :geoshape, String, description: 'GeoShape data for the location, if applicable'
     field :kind, String, description: 'Type of location'
     field :value, String, description: 'Name of location'
+
+    def geopoint
+      @object['geoshape']
+    end
   end
 
   class HighlightType < Types::BaseObject

test/controllers/graphql_controller_v2_test.rb

@@ -460,6 +460,7 @@ def setup
                                   search(searchterm: "train stations") {
                                     records {
                                       locations {
+                                        geopoint
                                         geoshape
                                         kind
                                         value
@@ -473,7 +474,7 @@ def setup
       assert_not json['errors'].present?
       assert_equal(
         json['data']['search']['records'].first['locations'][0].keys.sort,
-        ["geoshape", "value", "kind"].sort
+        ["geopoint", "geoshape", "value", "kind"].sort
       )
     end
   end