TIMDEX source_link to sym

Author: JPrevost

app/helpers/search_helper.rb

@@ -15,17 +15,17 @@ def format_highlight_label(field_name)
   end
 
   def link_to_result(result)
-    if result['source_link'].present?
-      link_to(result[:title], result['source_link'])
+    if result[:source_link].present?
+      link_to(result[:title], result[:source_link])
     else
       result[:title]
     end
   end
 
   def view_online(result)
-    return unless result['source_link'].present?
+    return unless result[:source_link].present?
 
-    link_to 'View online', result['source_link'], class: 'button button-primary'
+    link_to 'View online', result[:source_link], class: 'button button-primary'
   end
 
   def view_record(record_id)

app/models/normalize_timdex_record.rb

@@ -25,7 +25,7 @@ def normalize
       dates:,
       contributors:,
       highlight:,
-      'source_link' => source_link
+      source_link:
     }
   end
 

test/helpers/search_helper_test.rb

@@ -27,7 +27,7 @@ class SearchHelperTest < ActionView::TestCase
   end
 
   test 'renders view_online link if source_link is present' do
-    result = { title: 'A record', 'source_link' => 'https://example.org' }
+    result = { title: 'A record', source_link: 'https://example.org' }
     assert_equal '<a class="button button-primary" href="https://example.org">View online</a>',
                  view_online(result)
   end
@@ -170,7 +170,7 @@ class SearchHelperTest < ActionView::TestCase
   test 'link_to_result returns link when source_link is present' do
     result = {
       title: 'Sample Document Title',
-      'source_link' => 'https://example.com/document'
+      source_link: 'https://example.com/document'
     }
     expected_link = '<a href="https://example.com/document">Sample Document Title</a>'
     assert_equal expected_link, link_to_result(result)
@@ -179,15 +179,15 @@ class SearchHelperTest < ActionView::TestCase
   test 'link_to_result returns plain title when source_link is nil' do
     result = {
       title: 'Sample Document Title',
-      'source_link' => nil
+      source_link: nil
     }
     assert_equal 'Sample Document Title', link_to_result(result)
   end
 
   test 'link_to_result returns plain title when source_link is empty string' do
     result = {
       title: 'Sample Document Title',
-      'source_link' => ''
+      source_link: ''
     }
     assert_equal 'Sample Document Title', link_to_result(result)
   end

test/models/normalize_timdex_record_test.rb

@@ -204,7 +204,7 @@ def minimal_record
 
   test 'includes TIMDEX-specific source_link field' do
     normalized = NormalizeTimdexRecord.new(full_record, 'test').normalize
-    assert_equal 'https://example.com/source/record/123', normalized['source_link']
+    assert_equal 'https://example.com/source/record/123', normalized[:source_link]
   end
 
   # Test that Primo-only fields are not included

test/models/normalize_timdex_results_test.rb

@@ -31,7 +31,7 @@ def empty_timdex_response
     assert_includes first_result.keys, :dates
     assert_includes first_result.keys, :contributors
     assert_includes first_result.keys, :highlight
-    assert_includes first_result.keys, 'source_link'
+    assert_includes first_result.keys, :source_link
 
     # Check second record (minimal record)
     second_result = results.second