Skip to content

Commit 911752f

Browse files
committed
Reorganize rules in timdexui.scss
Why these changes are being introduced: There are some CSS rules in `timdexui.scss` with a note that they should be moved out of a file if there's a better place to put them. Since then, we've added several partials that might make logical sense to contain to these rules. Relevant ticket(s): N/A. How this addresses that need: This makes the following changes to `timdexui.scss`: * The `#advanced-search-panel legend` rule moves to the `panels` partial. (Though, it would also make sense in the `search` partial.) * The `.top-space` rule moves to the `results` partial, as it is only used for the filter container spacing. * The `.top-attached` and `.top-line` rules are removed. Currently, `.top-line` is only used in the style guide layout, and `.top-attached` appears not to be used anywhere. Side effects of this change: The style guide layout will no longer have a top border.
1 parent b2c8911 commit 911752f

File tree

3 files changed

+8
-17
lines changed

3 files changed

+8
-17
lines changed

app/assets/stylesheets/partials/_panels.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,7 @@
7272
}
7373
}
7474
}
75+
76+
#advanced-search-panel legend {
77+
color: #000
78+
}

app/assets/stylesheets/partials/_results.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
.top-space {
2+
margin-top: 2.4rem;
3+
}
4+
15
.wrap-results {
26
margin-bottom: 3rem;
37
background-color: $white-t;
Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,3 @@
11
body {
22
font-family: 'Roboto', 'Helvetica Neue', Helvetica, Arial, sans-serif;
33
}
4-
5-
// Things I don't know how to classify yet. Ideally this will be empty.
6-
.top-line {
7-
border-top: 1px solid #000;
8-
}
9-
10-
.top-attached {
11-
margin-top: 0;
12-
}
13-
14-
.top-space {
15-
margin-top: 2.4rem;
16-
}
17-
18-
#advanced-search-panel legend {
19-
color: #000
20-
}

0 commit comments

Comments
 (0)