Merge pull request #67 from MITLibraries/rdi-237-adv-search-fix

Display complete input values in advanced search form

Author: jazairi

app/views/search/_form.html.erb

@@ -30,37 +30,37 @@ end
       <div class="field-container">
         <div class="field-wrap">
           <label for="advanced-citation" class="field-label">Citation</label>
-          <input type="text" class="field field-text wide" id="advanced-citation" name="citation" placeholder="Citation" value=<%= params[:citation] %>>
+          <input type="text" class="field field-text wide" id="advanced-citation" name="citation" placeholder="Citation" value="<%= params[:citation] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-contributors" class="field-label">Contributors</label>
-          <input type="text" class="field field-text wide" id="advanced-contributors" name="contributors" placeholder="Contributors" value=<%= params[:contributors] %>>
+          <input type="text" class="field field-text wide" id="advanced-contributors" name="contributors" placeholder="Contributors" value="<%= params[:contributors] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-fundingInformation" class="field-label">Funding information</label>
-          <input type="text" class="field field-text wide" id="advanced-fundingInformation" name="fundingInformation" placeholder="Funding information" value=<%= params[:fundingInformation] %>>
+          <input type="text" class="field field-text wide" id="advanced-fundingInformation" name="fundingInformation" placeholder="Funding information" value="<%= params[:fundingInformation] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-identifiers" class="field-label">Identifiers</label>
-          <input type="text" class="field field-text wide" id="advanced-identifiers" name="identifiers" placeholder="Identifiers" value=<%= params[:identifiers] %>>
+          <input type="text" class="field field-text wide" id="advanced-identifiers" name="identifiers" placeholder="Identifiers" value="<%= params[:identifiers] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-locations" class="field-label">Locations</label>
-          <input type="text" class="field field-text wide" id="advanced-locations" name="locations" placeholder="Locations" value=<%= params[:locations] %>>
+          <input type="text" class="field field-text wide" id="advanced-locations" name="locations" placeholder="Locations" value="<%= params[:locations] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-subjects" class="field-label">Subjects</label>
-          <input type="text" class="field field-text wide" id="advanced-subjects" name="subjects" placeholder="Subjects" value=<%= params[:subjects] %>>
+          <input type="text" class="field field-text wide" id="advanced-subjects" name="subjects" placeholder="Subjects" value="<%= params[:subjects] %>">
         </div>
 
         <div class="field-wrap">
           <label for="advanced-title" class="field-label">Title</label>
-          <input type="text" class="field field-text wide" id="advanced-title" name="title" placeholder="Title" value=<%= params[:title] %>>
+          <input type="text" class="field field-text wide" id="advanced-title" name="title" placeholder="Title" value="<%= params[:title] %>">
         </div>
 
         <div class="field-wrap list-checkboxes">

test/controllers/search_controller_test.rb

@@ -321,6 +321,36 @@ class SearchControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test 'advanced search form retains values with spaces' do
+    VCR.use_cassette('advanced all spaces',
+                     allow_playback_repeats: true,
+                     match_requests_on: %i[method uri body]) do
+      query = {
+        q: 'some data',
+        citation: 'a citation',
+        contributors: 'some contribs',
+        fundingInformation: 'a fund',
+        identifiers: 'some ids',
+        locations: 'some locs',
+        subjects: 'some subs',
+        title: 'a title',
+        advanced: 'true'
+      }.to_query
+      get "/results?#{query}"
+      assert_response :success
+      assert_nil flash[:error]
+
+      assert_select 'input#basic-search-main', value: 'some data'
+      assert_select 'input#advanced-citation', value: 'a citation'
+      assert_select 'input#advanced-contributors', value:'some contribs'
+      assert_select 'input#advanced-fundingInformation', value: 'a fund'
+      assert_select 'input#advanced-identifiers', value: 'some ids'
+      assert_select 'input#advanced-locations', value: 'some locs'
+      assert_select 'input#advanced-subjects', value: 'some subs'
+      assert_select 'input#advanced-title', value: 'a title'
+    end
+  end
+
   def source_facet_count(controller)
     controller.view_context.assigns['facets']['source'].count
   end