Replace FlipFlip with Feature flag system

https://mitlibraries.atlassian.net/browse/USE-77

Author: JPrevost

README.md

@@ -93,7 +93,7 @@ See `Optional Environment Variables` for more information.
 - `BOOLEAN_OPTIONS`: comma separated list of values to present to testers on instances where `BOOLEAN_PICKER` feature is enabled.
 - `FEATURE_BOOLEAN_PICKER`: feature to allow users to select their preferred boolean type. If set to `true`, feature is enabled. This feature is only intended for internal team
   testing and should never be enabled in production (mostly because the UI is a mess more than it would cause harm).
-- `FEATURE_GDT`: Enables features related to geospatial data discovery. Setting this variable to `true` will trigger geodata
+- `FEATURE_GEODATA`: Enables features related to geospatial data discovery. Setting this variable to `true` will trigger geodata
 mode. Note that this is currently intended _only_ for the geodata app and
 may have unexpected consequences if applied to other TIMDEX UI apps.
 - `FILTER_ACCESS_TO_FILES`: The name to use instead of "Access to files" for that filter / aggregation.

app/controllers/search_controller.rb

@@ -1,7 +1,7 @@
 class SearchController < ApplicationController
   before_action :validate_q!, only: %i[results]
 
-  if Flipflop.enabled?(:gdt)
+  if Feature.enabled?(:geodata)
     before_action :validate_geobox_presence!, only: %i[results]
     before_action :validate_geobox_range!, only: %i[results]
     before_action :validate_geobox_values!, only: %i[results]
@@ -16,15 +16,15 @@ def results
     params[:booleanType] = cookies[:boolean_type] || 'AND'
 
     # Determine which tab to load - default to primo unless gdt is enabled
-    @active_tab = if Flipflop.enabled?(:gdt)
+    @active_tab = if Feature.enabled?(:geodata)
                     'gdt' # Keep existing GDT behavior unchanged
                   else
                     params[:tab] || 'primo' # Default to primo for new tabbed interface
                   end
     @enhanced_query = Enhancer.new(params).enhanced_query
 
     # Route to appropriate search based on active tab
-    if Flipflop.enabled?(:gdt)
+    if Feature.enabled?(:geodata)
       # Keep existing GDT behavior unchanged
       load_gdt_results
       render 'results_geo'

app/helpers/search_helper.rb

@@ -77,7 +77,7 @@ def applied_advanced_terms(query)
   # Query params need some treatment to look decent in the search summary panel.
   def readable_param(param)
     return 'Keyword anywhere' if param == 'q'
-    return 'Authors' if param == 'contributors' && Flipflop.enabled?(:gdt)
+    return 'Authors' if param == 'contributors' && Feature.enabled?(:geodata)
 
     if param.starts_with?('geodistance')
       param = param.gsub('geodistance', '')

app/models/enhancer.rb

@@ -14,7 +14,7 @@ def initialize(params)
     @enhanced_query[:advanced] = 'true' if params[:advanced].present?
     @enhanced_query[:booleanType] = params[:booleanType] || 'AND'
 
-    if Flipflop.enabled?(:gdt)
+    if Feature.enabled?(:geodata)
       @enhanced_query[:geobox] = 'true' if params[:geobox] == 'true'
       @enhanced_query[:geodistance] = 'true' if params[:geodistance] == 'true'
     end
@@ -38,7 +38,7 @@ def extract_query(params)
   end
 
   def extract_geosearch(params)
-    return unless Flipflop.enabled?(:gdt)
+    return unless Feature.enabled?(:geodata)
 
     GEO_PARAMS.each do |gp|
       @enhanced_query[gp] = params[gp] if params[gp].present?

app/models/query_builder.rb

@@ -12,7 +12,7 @@ def initialize(enhanced_query)
     @query = {}
     @query['from'] = calculate_from(enhanced_query[:page])
 
-    if Flipflop.enabled?(:gdt)
+    if Feature.enabled?(:geodata)
       @query['geobox'] = 'true' if enhanced_query[:geobox] == 'true'
       @query['geodistance'] = 'true' if enhanced_query[:geodistance] == 'true'
     end
@@ -40,7 +40,7 @@ def extract_query(enhanced_query)
   end
 
   def extract_geosearch(enhanced_query)
-    return unless Flipflop.enabled?(:gdt)
+    return unless Feature.enabled?(:geodata)
 
     GEO_PARAMS.each do |gp|
       if coerce_to_float?(gp)

app/views/basic_search/index.html.erb

@@ -2,6 +2,6 @@
 
 <main class="space-wrap">
   <%= render partial: "shared/site_title" %>
-  <%= render partial: "search/form_geo" if Flipflop.enabled?(:gdt) %>
+  <%= render partial: "search/form_geo" if Feature.enabled?(:geodata) %>
   <%= render partial: "static/about" if ENV.fetch('ABOUT_APP', nil) %>
 </main>

app/views/layouts/_site_header.html.erb

@@ -20,12 +20,12 @@
       </h1>
       <nav class="main-navigation" aria-label="Main navigation">
           <%= nav_link_to("Home", root_path) %>
-          <% if Flipflop.enabled?(:gdt) %>
+          <% if Feature.enabled?(:geodata) %>
               <%= nav_link_to("GIS at MIT", "https://libraries.mit.edu/gis") %>
               <%= nav_link_to("Ask GIS", "https://libraries.mit.edu/ask-gis") %>
           <% end %>
       </nav>
     </header>
-    <%= render partial: 'search/form' unless Flipflop.enabled?(:gdt) %>
+    <%= render partial: 'search/form' unless Feature.enabled?(:geodata) %>
   </div>  
-</div>
+</div>

app/views/record/_sidebar.html.erb

@@ -1,15 +1,15 @@
-<% if Flipflop.enabled?(:gdt) %>
+<% if Feature.enabled?(:geodata) %>
   <div role="region" aria-label="Access and help links" class="col1q-r sidebar access-sidebar">
 <% else %>
   <aside class="col1q-r sidebar">
 <% end %>
-  <% if Flipflop.enabled?(:gdt) && access_type(@record) && gis_access_link(@record) %>
+  <% if Feature.enabled?(:geodata) && access_type(@record) && gis_access_link(@record) %>
     <h2 class="hd-3">Access links</h2>
     <%= render partial: 'access_buttons' %>
   <% end %>
 
    <%= render partial: 'shared/ask', locals: { display: '' } %>
-<% if Flipflop.enabled?(:gdt) %>
+<% if Feature.enabled?(:geodata) %>
   </div>
 <% else %>
   </aside>

app/views/record/view.html.erb

@@ -12,7 +12,7 @@
 
 <% if @record.nil? %>
   <%= render('record_empty') %>
-<% elsif Flipflop.enabled?(:gdt) %>
+<% elsif Feature.enabled?(:geodata) %>
   <%= render('record_geo') %>
 <% else %>
   <%= render('record') %>

app/views/search/_filter.html.erb

@@ -15,7 +15,7 @@
           <a href="<%= results_path(add_filter(@enhanced_query, category, term['key'])) %>">
           <span class="sr">Apply filter:</span>
         <% end %>
-        <% if Flipflop.enabled?(:gdt) %>
+        <% if Feature.enabled?(:geodata) %>
           <span class="name"><%= gdt_sources(term['key'], category) %></span>
         <% else %>
           <span class="name"><%= term['key'] %></span>