Skip to content

Commit bbd23ed

Browse files
committed
Utilize updated TDA loading and reading
Why these changes are being introduced: With recent TDA updates, we no longer requiring .load() called on TIMDEXDataset. This moves some filtering into the read methods. How this addresses that need: * Remove .load() usage for TIMDEXDataset * Update read methods * Update dataset fixture to reflect new structure Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-536
1 parent d5e915c commit bbd23ed

12 files changed

+23
-24
lines changed

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ line-length = 90
44
[tool.mypy]
55
disallow_untyped_calls = true
66
disallow_untyped_defs = true
7-
exclude = ["tests/"]
7+
exclude = ["tests/", "output/"]
88

99
[[tool.mypy.overrides]]
1010
module = ["ijson", "smart_open", "timdex_dataset_api"]
@@ -43,8 +43,7 @@ ignore = [
4343
"PLR0912",
4444
"PLR0913",
4545
"PLR0915",
46-
"S320",
47-
"S321",
46+
"S321",
4847
]
4948

5049
# allow autofix behavior for specified rules

tests/conftest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ def runner():
3838

3939
@pytest.fixture
4040
def timdex_dataset() -> TIMDEXDataset:
41-
td = TIMDEXDataset("tests/fixtures/dataset")
42-
td.load()
43-
return td
41+
return TIMDEXDataset("tests/fixtures/dataset")
4442

4543

4644
@pytest.fixture
524 KB
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)