Cleanup some names

Author: cabutlermit

README.md

@@ -209,10 +209,10 @@ This is a core infrastructure repository that defines infrastructure related to
 | alma\_webhook\_lambdas\_makefile | Full contents of the Makefile for the alma-webhook-lambdas repo (allows devs to push to Dev account only) |
 | alma\_webhook\_lambdas\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the alma-webhook-lambdas repo |
 | alma\_webhook\_lambdas\_stage\_build\_workflow | Full contents of the stage-build.yml for the alma-webhook-lambdas repo |
-| apt\_fargate\_dev\_build\_workflow | Full contents of the dev-build.yml for the archival-packaging-tool repo |
-| apt\_fargate\_makefile | Full contents of the Makefile for the archival-packaging-tool repo (allows devs to push to Dev account only) |
-| apt\_fargate\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the archival-packaging-tool repo |
-| apt\_fargate\_stage\_build\_workflow | Full contents of the stage-build.yml for the archival-packaging-tool repo |
+| apt\_dev\_build\_workflow | Full contents of the dev-build.yml for the archival-packaging-tool repo |
+| apt\_makefile | Full contents of the Makefile for the archival-packaging-tool repo (allows devs to push to Dev account only) |
+| apt\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the archival-packaging-tool repo |
+| apt\_stage\_build\_workflow | Full contents of the stage-build.yml for the archival-packaging-tool repo |
 | asati\_fargate\_dev\_build\_workflow | Full contents of the dev-build.yml for the asati repo |
 | asati\_fargate\_makefile | Full contents of the Makefile for the asati repo (allows devs to push to Dev account only) |
 | asati\_fargate\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the asati repo |

apt_ecr.tf

@@ -21,47 +21,47 @@ module "ecr_apt" {
 
 ## For archival-packaging-tool application repo and ECR repository
 # Outputs in dev
-output "apt_fargate_dev_build_workflow" {
+output "apt_dev_build_workflow" {
   value = var.environment == "prod" || var.environment == "stage" ? null : templatefile("${path.module}/files/dev-build.tpl", {
     region   = var.aws_region
     role     = module.ecr_apt.gha_role
     ecr      = module.ecr_apt.repository_name
-    function = ""
+    function = local.ecr_apt
     }
   )
   description = "Full contents of the dev-build.yml for the archival-packaging-tool repo"
 }
-output "apt_fargate_makefile" {
+output "apt_makefile" {
   value = var.environment == "prod" || var.environment == "stage" ? null : templatefile("${path.module}/files/makefile.tpl", {
     ecr_name = module.ecr_apt.repository_name
     ecr_url  = module.ecr_apt.repository_url
-    function = ""
+    function = local.ecr_apt
     }
   )
   description = "Full contents of the Makefile for the archival-packaging-tool repo (allows devs to push to Dev account only)"
 }
 
 # Outputs in stage
-output "apt_fargate_stage_build_workflow" {
+output "apt_stage_build_workflow" {
   value = var.environment == "prod" || var.environment == "dev" ? null : templatefile("${path.module}/files/stage-build.tpl", {
     region   = var.aws_region
     role     = module.ecr_apt.gha_role
     ecr      = module.ecr_apt.repository_name
-    function = ""
+    function = local.ecr_apt
     }
   )
   description = "Full contents of the stage-build.yml for the archival-packaging-tool repo"
 }
 
 # Outputs after promotion to prod
-output "apt_fargate_prod_promote_workflow" {
+output "apt_prod_promote_workflow" {
   value = var.environment == "stage" || var.environment == "dev" ? null : templatefile("${path.module}/files/prod-promote.tpl", {
     region     = var.aws_region
     role_stage = "${module.ecr_apt.repo_name}-gha-stage"
     role_prod  = "${module.ecr_apt.repo_name}-gha-prod"
     ecr_stage  = "${module.ecr_apt.repo_name}-stage"
     ecr_prod   = "${module.ecr_apt.repo_name}-prod"
-    function   = ""
+    function   = local.ecr_apt
     }
   )
   description = "Full contents of the prod-promote.yml for the archival-packaging-tool repo"

files/prod-promote-extra-region.tpl

@@ -1,4 +1,4 @@
-### This should be added to jobs section of the dev-build.yml.
+### This should be added to jobs section of the prod-promote.yml.
 ### If this is a Lambda function, uncomment the FUNCTION: line
 
   deploy-${region}: