Fix Typo for Browsertrix

Why these changes are being introduced:
The code for the browsertrix app had some misspellings in it (where the
"ws" was sometimes transposed as "sw"). This fixes that without making
any changes to the deployed infrastructure.

How this addresses that need:
* Fix all the misspellings of "browsertrix" in the code
* Create a number of `moved {}` blocks to ensure that after the
misspellings are fixed, no infrastructure related to browsertrix is
changed
* Update README

Side effects of this change:
None.

Author: cabutlermit

README.md

@@ -88,7 +88,7 @@ then replace all the ssm parameter references for `oidc_arn` with `aws_iam_openi
 | ecr\_ppod | ./modules/ecr | n/a |
 | ecr\_sapinvoices | ./modules/ecr | n/a |
 | ecr\_slingshot | ./modules/ecr | n/a |
-| ecr\_timdex\_broswertrix | ./modules/ecr | n/a |
+| ecr\_timdex\_browsertrix | ./modules/ecr | n/a |
 | ecr\_timdex\_geo | ./modules/ecr | n/a |
 | ecr\_timdex\_lambdas | ./modules/ecr | n/a |
 | ecr\_timdex\_tim | ./modules/ecr | n/a |
@@ -125,10 +125,10 @@ then replace all the ssm parameter references for `oidc_arn` with `aws_iam_openi
 | alma\_webhook\_lambdas\_makefile | Full contents of the Makefile for the alma-webhook-lambdas repo (allows devs to push to Dev account only) |
 | alma\_webhook\_lambdas\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the alma-webhook-lambdas repo |
 | alma\_webhook\_lambdas\_stage\_build\_workflow | Full contents of the stage-build.yml for the alma-webhook-lambdas repo |
-| broswertrix\_dev\_build\_workflow | Full contents of the dev-build.yml for the browsertrix-harvester repo |
-| broswertrix\_makefile | Full contents of the Makefile for the browsertrix-harvester repo (allows devs to push to Dev account only) |
-| broswertrix\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the browsertrix-harvester repo |
-| broswertrix\_stage\_build\_workflow | Full contents of the stage-build.yml for the browsertrix-harvester repo |
+| browsertrix\_dev\_build\_workflow | Full contents of the dev-build.yml for the browsertrix-harvester repo |
+| browsertrix\_makefile | Full contents of the Makefile for the browsertrix-harvester repo (allows devs to push to Dev account only) |
+| browsertrix\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the browsertrix-harvester repo |
+| browsertrix\_stage\_build\_workflow | Full contents of the stage-build.yml for the browsertrix-harvester repo |
 | bursar\_dev\_build\_workflow | Full contents of the dev-build.yml for the alma-bursartransfer repo |
 | bursar\_makefile | Full contents of the Makefile for the alma-bursartransfer repo (allows devs to push to Dev account only) |
 | bursar\_prod\_promote\_workflow | Full contents of the prod-promote.yml for the alma-bursartransfer repo |

timdex_ecrs.tf

@@ -247,7 +247,7 @@ output "tim_prod_promote_workflow" {
 
 ## browsertrix-harvester
 # browsertrix-harvester ECR repository
-module "ecr_timdex_broswertrix" {
+module "ecr_timdex_browsertrix" {
   source            = "./modules/ecr"
   repo_name         = "browsertrix-harvester"
   login_policy_arn  = aws_iam_policy.login.arn
@@ -258,50 +258,75 @@ module "ecr_timdex_broswertrix" {
     app-repo = "timdex-infrastructure-browsertrix"
   }
 }
+# NEED TO FIX THE MISSPELLING!!!
+moved {
+  from = module.ecr_timdex_broswertrix
+  to   = module.ecr_timdex_browsertrix
+}
 # Outputs in dev
-output "broswertrix_dev_build_workflow" {
+output "browsertrix_dev_build_workflow" {
   value = var.environment == "prod" || var.environment == "stage" ? null : templatefile("${path.module}/files/dev-build.tpl", {
     region   = var.aws_region
-    role     = module.ecr_timdex_broswertrix.gha_role
-    ecr      = module.ecr_timdex_broswertrix.repository_name
+    role     = module.ecr_timdex_browsertrix.gha_role
+    ecr      = module.ecr_timdex_browsertrix.repository_name
     function = ""
     }
   )
   description = "Full contents of the dev-build.yml for the browsertrix-harvester repo"
 }
-output "broswertrix_makefile" {
+# NEED TO FIX THE MISSPELLING!!!
+moved {
+  from = output.broswertrix_dev_build_workflow
+  to   = output.browsertrix_dev_build_workflow
+}
+output "browsertrix_makefile" {
   value = var.environment == "prod" || var.environment == "stage" ? null : templatefile("${path.module}/files/makefile.tpl", {
-    ecr_name = module.ecr_timdex_broswertrix.repository_name
-    ecr_url  = module.ecr_timdex_broswertrix.repository_url
+    ecr_name = module.ecr_timdex_browsertrix.repository_name
+    ecr_url  = module.ecr_timdex_browsertrix.repository_url
     function = ""
     }
   )
   description = "Full contents of the Makefile for the browsertrix-harvester repo (allows devs to push to Dev account only)"
 }
+# NEED TO FIX THE MISSPELLING!!!
+moved {
+  from = output.broswertrix_makefile
+  to   = output.browsertrix_makefile
+}
 # Outputs in stage
-output "broswertrix_stage_build_workflow" {
+output "browsertrix_stage_build_workflow" {
   value = var.environment == "prod" || var.environment == "dev" ? null : templatefile("${path.module}/files/stage-build.tpl", {
     region   = var.aws_region
-    role     = module.ecr_timdex_broswertrix.gha_role
-    ecr      = module.ecr_timdex_broswertrix.repository_name
+    role     = module.ecr_timdex_browsertrix.gha_role
+    ecr      = module.ecr_timdex_browsertrix.repository_name
     function = ""
     }
   )
   description = "Full contents of the stage-build.yml for the browsertrix-harvester repo"
 }
+# NEED TO FIX THE MISSPELLING!!!
+moved {
+  from = output.broswertrix_stage_build_workflow
+  to   = output.browsertrix_stage_build_workflow
+}
 # Outputs after promotion to prod
-output "broswertrix_prod_promote_workflow" {
+output "browsertrix_prod_promote_workflow" {
   value = var.environment == "stage" || var.environment == "dev" ? null : templatefile("${path.module}/files/prod-promote.tpl", {
     region     = var.aws_region
-    role_stage = "${module.ecr_timdex_broswertrix.repo_name}-gha-stage"
-    role_prod  = "${module.ecr_timdex_broswertrix.repo_name}-gha-prod"
-    ecr_stage  = "${module.ecr_timdex_broswertrix.repo_name}-stage"
-    ecr_prod   = "${module.ecr_timdex_broswertrix.repo_name}-prod"
+    role_stage = "${module.ecr_timdex_browsertrix.repo_name}-gha-stage"
+    role_prod  = "${module.ecr_timdex_browsertrix.repo_name}-gha-prod"
+    ecr_stage  = "${module.ecr_timdex_browsertrix.repo_name}-stage"
+    ecr_prod   = "${module.ecr_timdex_browsertrix.repo_name}-prod"
     function   = ""
     }
   )
   description = "Full contents of the prod-promote.yml for the browsertrix-harvester repo"
 }
+# NEED TO FIX THE MISSPELLING!!!
+moved {
+  from = output.broswertrix_prod_promote_workflow
+  to   = output.browsertrix_prod_promote_workflow
+}
 
 
 ## geo-harvester