Further tests for TFormat_XX, TFormat_ESCAPE and TFormat_Radxix64, testing that exceptions are properly raised.

Author: MHumm

Unit Tests/Tests/TestDECFormat.pas

@@ -377,6 +377,7 @@   TestTFormat_Radix64 = class(TFormatTestsBase)
     procedure TearDown; override;
 
     procedure DoSetCharsPerLine0;
+    procedure DoTestCRCException;
   published
     procedure TestEncodeBytes;
     procedure TestEncodeRawByteString;
@@ -391,6 +392,7 @@   TestTFormat_Radix64 = class(TFormatTestsBase)
     procedure TestClassByName;
     procedure TestIdentity;
     procedure SetCharsPerLine0Exception;
+    procedure TestCRCException;
   end;
 
   // Test methods for class TFormat_UU
@@ -644,6 +646,8 @@   TestTFormat_XX = class(TFormatTestsBase)
   public
     procedure SetUp; override;
     procedure TearDown; override;
+  private
+    procedure DoTestDecodeException;
   published
     procedure TestEncodeBytes;
     procedure TestEncodeRawByteString;
@@ -656,6 +660,7 @@   TestTFormat_XX = class(TFormatTestsBase)
     procedure TestIsValidRawByteString;
     procedure TestClassByName;
     procedure TestIdentity;
+    procedure TestDecodeException;
   end;
 
   // Test methods for class TFormat_ESCAPE
@@ -745,6 +750,10 @@   TestTFormat_ESCAPE = class(TFormatTestsBase)
   public
     procedure SetUp; override;
     procedure TearDown; override;
+  protected
+    procedure DoTestDecodeExceptionWrongChar;
+    procedure DoTestDecodeExceptionWrongChar2;
+    procedure DoTestDecodeExceptionWrongLength;
   published
     procedure TestEncodeBytes;
     procedure TestEncodeRawByteString;
@@ -757,6 +766,7 @@   TestTFormat_ESCAPE = class(TFormatTestsBase)
     procedure TestIsValidRawByteString;
     procedure TestClassByName;
     procedure TestIdentity;
+    procedure TestDecodeException;
   end;
 
   // Test methods for class TFormat_BigEndian16
@@ -1304,6 +1314,11 @@ procedure TestTFormat_Radix64.DoSetCharsPerLine0;
   FFormat_Radix64.SetCharsPerLine(0);
 end;
 
+procedure TestTFormat_Radix64.DoTestCRCException;
+begin
+  FFormat_Radix64.Decode('VGVzdAoJqlU=' + #13 + #10 +'=XtiN');
+end;
+
 procedure TestTFormat_Radix64.SetCharsPerLine0Exception;
 begin
   CheckException(DoSetCharsPerLine0, EArgumentOutOfRangeException);
@@ -1367,6 +1382,11 @@ procedure TestTFormat_Radix64.TestClassByName;
   CheckEquals(TFormat_Radix64, ReturnValue, 'Class is not registered');
 end;
 
+procedure TestTFormat_Radix64.TestCRCException;
+begin
+  CheckException(DoTestCRCException, EDECFormatException);
+end;
+
 procedure TestTFormat_Radix64.TestDecodeBytes;
 begin
   DoTestEncodeDecode(FFormat_Radix64.Decode, cTestDataDecode);
@@ -1662,6 +1682,11 @@ procedure TestTFormat_UU.TestIsValidTypeless;
   end;
 end;
 
+procedure TestTFormat_XX.DoTestDecodeException;
+begin
+  FFormat_XX.Decode('ä');
+end;
+
 procedure TestTFormat_XX.SetUp;
 begin
   FFormat_XX := TFormat_XX.Create;
@@ -1686,6 +1711,11 @@ procedure TestTFormat_XX.TestDecodeBytes;
   DoTestEncodeDecode(FFormat_XX.Decode, cTestDataDecode);
 end;
 
+procedure TestTFormat_XX.TestDecodeException;
+begin
+  CheckException(DoTestDecodeException, EDECFormatException);
+end;
+
 procedure TestTFormat_XX.TestDecodeRawByteString;
 begin
   DoTestEncodeDecodeRawByteString(FFormat_XX.Decode, cTestDataDecode);
@@ -1837,6 +1867,21 @@ procedure TestTFormat_XX.TestIsValidTypeless;
   end;
 end;
 
+procedure TestTFormat_ESCAPE.DoTestDecodeExceptionWrongChar;
+begin
+  FFormat_ESCAPE.Decode(RawByteString('\xä'));
+end;
+
+procedure TestTFormat_ESCAPE.DoTestDecodeExceptionWrongChar2;
+begin
+  FFormat_ESCAPE.Decode(RawByteString('\xaä'));
+end;
+
+procedure TestTFormat_ESCAPE.DoTestDecodeExceptionWrongLength;
+begin
+  FFormat_ESCAPE.Decode(RawByteString('\xaa\x'));
+end;
+
 procedure TestTFormat_ESCAPE.SetUp;
 begin
   FFormat_ESCAPE := TFormat_ESCAPE.Create;
@@ -1861,6 +1906,13 @@ procedure TestTFormat_ESCAPE.TestDecodeBytes;
   DoTestEncodeDecode(FFormat_ESCAPE.Decode, cTestDataDecode);
 end;
 
+procedure TestTFormat_ESCAPE.TestDecodeException;
+begin
+  CheckException(DoTestDecodeExceptionWrongChar, EDECFormatException);
+  CheckException(DoTestDecodeExceptionWrongChar2, EDECFormatException);
+  CheckException(DoTestDecodeExceptionWrongLength, EDECFormatException);
+end;
+
 procedure TestTFormat_ESCAPE.TestDecodeRawByteString;
 begin
   DoTestEncodeDecodeRawByteString(FFormat_ESCAPE.Decode, cTestDataDecode);