Add more specs/reorganize

Author: mfeniseycopes

spec/helpers.spec.js

@@ -18,6 +18,6 @@ context('Helpers', () => {
     it('should format a time given a Date object', () => {
       const time = new Date('December 25, 1995 23:15:30');
       expect(formatTime(time)).to.equal('23:15:30.000');
-    });
+   });
   });
 });

spec/index.spec.js

@@ -22,27 +22,54 @@ context('default logger', () => {
 });
 
 context('createLogger', () => {
-  describe('init', () => {
+  beforeEach(() => {
+    sinon.spy(console, 'error');
+    sinon.spy(console, 'log');
+  });
+
+  afterEach(() => {
+    console.error.restore();
+    console.log.restore();
+  });
+
+  let store;
+
+  context('mistakenly passed directly to applyMiddleware', () => {
     beforeEach(() => {
-      sinon.spy(console, 'error');
+      store = createStore(() => ({}), applyMiddleware(createLogger));
     });
 
-    afterEach(() => {
-      console.error.restore();
+    it('should log error', () => {
+      sinon.assert.calledOnce(console.error);
     });
 
-    it('should throw error if passed direct to applyMiddleware', () => {
-      const store = createStore(() => ({}), applyMiddleware(createLogger));
+    it('should create an empty middleware', () => {
+      store.dispatch({ type: 'foo' });
+      sinon.assert.notCalled(console.log);
+    });
+  });
+
+  context('options.logger undefined or null', () => {
+    beforeEach(() => {
+      const logger = createLogger({ logger: null });
+      store = createStore(() => ({}), applyMiddleware(logger));  
+    }); 
 
+    it('should create an empty middleware', () => {
       store.dispatch({ type: 'foo' });
-      sinon.assert.calledOnce(console.error);
+      sinon.assert.notCalled(console.log);
     });
+  });
 
-    it('should be ok', () => {
-      const store = createStore(() => ({}), applyMiddleware(createLogger()));
+  context('options.predicate returns false', () => {
+    beforeEach(() => {
+      const logger = createLogger({ predicate: () => false });
+      store = createStore(() => ({}), applyMiddleware(logger));  
+    }); 
 
+    it('should not log', () => {
       store.dispatch({ type: 'foo' });
-      sinon.assert.notCalled(console.error);
+      sinon.assert.notCalled(console.log);
     });
   });
 });

src/index.js

@@ -69,14 +69,14 @@ function createLogger(options = {}) {
     return emptyLogger();
   }
 
-  const loggerOptions = Object.assign({}, defaults, options):
+  const loggerOptions = Object.assign({}, defaults, options);
 
   // Return if 'console' object is not defined
   if (noLogger(loggerOptions)) return emptyLogger();
 
   return ({ getState }) => next => (action) => {
     // Exit early if predicate function returns 'false'
-    if (shouldNotLog(getState, action)) return next(action);
+    if (shouldNotLog(options, getState, action)) return next(action);
 
     const started = timer.now();
     const startedTime = new Date();