Add more specs/reorganize

Author: mfeniseycopes

spec/helpers.spec.js

@@ -0,0 +1,11 @@
+import { expect } from 'chai';
+
+import { repeat } from '../src/helpers';
+
+context(`Helpers`, () => {
+  describe(`repeat`, () => {
+    it(`should repeat a string the number of indicated times`, () => {
+      expect(repeat(`teacher`, 3)).to.equal(`teacherteacherteacher`);
+    });
+  });
+});

spec/index.spec.js

@@ -1,19 +1,8 @@
-import { expect } from 'chai';
 import sinon from 'sinon';
-
 import { applyMiddleware, createStore } from 'redux';
 
-import { repeat } from 'helpers';
 import logger, { createLogger } from '../src';
 
-context(`Helpers`, () => {
-  describe(`repeat`, () => {
-    it(`should repeat a string the number of indicated times`, () => {
-      expect(repeat(`teacher`, 3)).to.equal(`teacherteacherteacher`);
-    });
-  });
-});
-
 context(`default logger`, () => {
   describe(`init`, () => {
     beforeEach(() => {
@@ -34,27 +23,54 @@ context(`default logger`, () => {
 });
 
 context(`createLogger`, () => {
-  describe(`init`, () => {
+  beforeEach(() => {
+    sinon.spy(console, `error`);
+    sinon.spy(console, 'log');
+  });
+
+  afterEach(() => {
+    console.error.restore();
+    console.log.restore();
+  });
+
+  let store;
+
+  context('mistakenly passed directly to applyMiddleware', () => {
     beforeEach(() => {
-      sinon.spy(console, `error`);
+      store = createStore(() => ({}), applyMiddleware(createLogger));
     });
 
-    afterEach(() => {
-      console.error.restore();
+    it('should log error', () => {
+      sinon.assert.calledOnce(console.error);
     });
 
-    it(`should throw error if passed direct to applyMiddleware`, () => {
-      const store = createStore(() => ({}), applyMiddleware(createLogger));
-
+    it('should create an empty middleware', () => {
       store.dispatch({ type: `foo` });
-      sinon.assert.calledOnce(console.error);
+      sinon.assert.notCalled(console.log);
     });
+  });
 
-    it(`should be ok`, () => {
-      const store = createStore(() => ({}), applyMiddleware(createLogger()));
+  context('options.logger undefined or null', () => {
+    beforeEach(() => {
+      const logger = createLogger({ logger: null });
+      store = createStore(() => ({}), applyMiddleware(logger));  
+    }); 
 
-      store.dispatch({ type: `foo` });
-      sinon.assert.notCalled(console.error);
+    it('should create an empty middleware', () => {
+      store.dispatch({ type: 'foo' });
+      sinon.assert.notCalled(console.log);
+    });
+  });
+
+  context('options.predicate returns false', () => {
+    beforeEach(() => {
+      const logger = createLogger({ predicate: () => false });
+      store = createStore(() => ({}), applyMiddleware(logger));  
+    }); 
+
+    it('should not log', () => {
+      store.dispatch({ type: 'foo' });
+      sinon.assert.notCalled(console.log);
     });
   });
 });

src/index.js

@@ -79,7 +79,7 @@ function createLogger(options = {}) {
 
   return ({ getState }) => next => (action) => {
     // Exit early if predicate function returns 'false'
-    if (shouldNotLog(getState, action)) return next(action);
+    if (shouldNotLog(options, getState, action)) return next(action);
 
     const started = timer.now();
     const startedTime = new Date();