fix(clang-tidy): fixed all clang-tidy warnings within the library. Added exception for default destructor of special member functions in clang tidy.

Author: LinuxDevon

.clang-tidy

@@ -140,7 +140,7 @@ CheckOptions:
   readability-suspicious-call-argument.DiceSimilarAbove: '70'
   readability-suspicious-call-argument.Dice: 'true'
   readability-suspicious-call-argument.Abbreviation: 'true'
-  cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor: 'false'
+  cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor: 'true'
   readability-identifier-length.IgnoredLoopCounterNames: '^[ijk_]$'
   cert-dcl37-c.Invert: 'false'
   cert-dcl37-c.AggressiveDependentMemberLookup: 'false'

include/libdbc/dbc.hpp

@@ -23,28 +23,26 @@ class DbcParser : public Parser {
 public:
 	DbcParser();
 
-	virtual ~DbcParser() = default;
-
-	virtual void parse_file(const std::string& file) final override;
+	void parse_file(const std::string& file) override;
 
 	std::string get_version() const;
 	std::vector<std::string> get_nodes() const;
 	std::vector<libdbc::Message> get_messages() const;
 
-	Message::ParseSignalsStatus parseMessage(const uint32_t id, const std::vector<uint8_t>& data, std::vector<double>& out_values);
+	Message::ParseSignalsStatus parseMessage(uint32_t message_id, const std::vector<uint8_t>& data, std::vector<double>& out_values);
 
 private:
 	std::string version;
 	std::vector<std::string> nodes;
 	std::vector<libdbc::Message> messages;
 
-	const std::regex version_re;
-	const std::regex bit_timing_re;
-	const std::regex name_space_re;
-	const std::regex node_re;
-	const std::regex message_re;
-	const std::regex value_re;
-	const std::regex signal_re;
+	std::regex version_re;
+	std::regex bit_timing_re;
+	std::regex name_space_re;
+	std::regex node_re;
+	std::regex message_re;
+	std::regex value_re;
+	std::regex signal_re;
 
 	void parse_dbc_header(std::istream& file_stream);
 	void parse_dbc_nodes(std::istream& file_stream);

include/libdbc/exceptions/error.hpp

@@ -1,20 +1,20 @@
 #ifndef ERROR_HPP
 #define ERROR_HPP
 
-#include <sstream>
+#include <exception>
 
 namespace libdbc {
 
 class exception : public std::exception {
 public:
-	const char* what() const throw() {
+	const char* what() const throw() override {
 		return "libdbc exception occurred";
 	}
 };
 
 class validity_error : public exception {
 public:
-	const char* what() const throw() {
+	const char* what() const throw() override {
 		return "Invalid DBC file";
 	}
 };

include/libdbc/message.hpp

@@ -11,7 +11,7 @@ namespace libdbc {
 struct Message {
 	Message() = delete;
 	virtual ~Message() = default;
-	explicit Message(uint32_t id, const std::string& name, uint8_t size, const std::string& node);
+	explicit Message(uint32_t message_id, const std::string& name, uint8_t size, const std::string& node);
 
 	enum class ParseSignalsStatus {
 		Success,
@@ -39,7 +39,7 @@ struct Message {
 	std::string m_node;
 	std::vector<Signal> m_signals;
 
-	friend std::ostream& operator<<(std::ostream& os, const Message& dt);
+	friend std::ostream& operator<<(std::ostream& out, const Message& msg);
 };
 
 std::ostream& operator<<(std::ostream& out, const Message& msg);

include/libdbc/signal.hpp

@@ -41,7 +41,7 @@ struct Signal {
 					double min,
 					double max,
 					std::string unit,
-					std::vector<std::string> recievers);
+					std::vector<std::string> receivers);
 
 	virtual bool operator==(const Signal& rhs) const;
 	bool operator<(const Signal& rhs) const;

include/libdbc/utils/utils.hpp

@@ -35,10 +35,10 @@ class String {
 
 	template<class Container>
 	static void split(const std::string& str, Container& cont, char delim = ' ') {
-		std::stringstream ss(str);
+		std::stringstream stream(str);
 		std::string token;
 
-		while (std::getline(ss, token, delim)) {
+		while (std::getline(stream, token, delim)) {
 			cont.push_back(token);
 		}
 	}