Tried to add new symbol check but gave up. the standard conflicts and doesn't look like every dbc uses the same symbols either.

Author: LinuxDevon

src/dbc.hpp

@@ -2,6 +2,7 @@
 #include "util/utils.hpp"
 
 #include <regex>
+#include <iostream>
 
 namespace libdbc {
 
@@ -19,7 +20,7 @@ namespace libdbc {
 	class DbcParser : public Parser {
 	public:
 		DbcParser() : version(""), version_re("^(VERSION)\\s\"(.*)\""),
-					  bit_timing_re("^(BS_:)"), name_space_re("^(_NS)\\s \\:") {
+					  bit_timing_re("^(BS_:)"), name_space_re("^(NS_)\\s\\:") {
 
 		}
 
@@ -50,38 +51,13 @@ namespace libdbc {
 		const std::regex name_space_re;
 
 		void parse_dbc_header(std::istream& file_stream) {
+			std::vector<std::string> lines;
+
 			std::string line;
 			std::smatch match;
 			bool is_blank = true;
 			bool not_blank = true;
 
-			std::vector<std::string> symbols = {"CM_",
-											   "BA_DEF_",
-											   "BA_",
-											   "VAL",
-											   "CAT_DEF_",
-											   "CAT_",
-											   "FILTER",
-											   "BA_DEF_DEF_",
-											   "EV_DATA_",
-											   "ENVVAR_DATA_",
-											   "SGTYPE_",
-											   "SGTYPE_VALTYPE_",
-											   "BA_DEF_SGTYPE_",
-											   "BA_SGTYPE_",
-											   "SIG_TYPE_REF_",
-											   "VAL_TABLE_",
-											   "SIG_GROUP_",
-											   "SIG_VALTYPE_",
-											   "SIGTYPE_VALTYPE_",
-											   "BO_TX_BU_",
-											   "BA_DEF_REL_",
-											   "BA_REL_",
-											   "BA_DEF_DEF_REL_",
-											   "BU_SG_REL_",
-											   "BU_EV_REL_",
-											   "BU_BO_REL_"};
-
 			utils::StreamHandler::get_line(file_stream, line);
 
 			if(!std::regex_search(line, match, version_re)) {
@@ -100,9 +76,17 @@ namespace libdbc {
 				throw validity_error();
 
 		}
+		std::string trim(const std::string& line)
+		{
+			const char* WhiteSpace = " \t\v\r\n";
+			std::size_t start = line.find_first_not_of(WhiteSpace);
+			std::size_t end = line.find_last_not_of(WhiteSpace);
+			return start == end ? std::string() : line.substr(start, end - start + 1);
+		}
 
 	};
 
+
 	struct Message {
 
 	};

test/test_dbc.cpp

@@ -16,6 +16,12 @@ TEST_CASE("Testing dbc file loading error issues", "[fileio][error]") {
 	SECTION("Loading a dbc without the required bit timing section (BS_:)", "[error]") {
 		REQUIRE_THROWS_AS(parser->parse_file(MISSING_BIT_TIMING_DBC_FILE), libdbc::validity_error);
 	}
+
+	SECTION("Loading a dbc with some missing namespace section tags (_NS :)", "[error]") {
+		// Confusion about this type of error. it appears that the header isn't
+		// very well standardized for now we ignore this type of error.
+		CHECK_NOTHROW(parser->parse_file(MISSING_NEW_SYMBOLS_DBC_FILE));
+	}
 }
 
 TEST_CASE("Testing dbc file loading", "[fileio]") {