Skip to content

Commit 67a7b36

Browse files
committed
fix(test): Fixed the fast_float to original arithmetic in an attempt to fix the windows debug build
1 parent db27187 commit 67a7b36

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/utils.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ std::string String::trim(const std::string& line) {
7474

7575
double String::convert_to_double(const std::string& value, double default_value) {
7676
double converted_value = default_value;
77-
fast_float::from_chars(&(*value.begin()), &(*value.end()), converted_value);
77+
fast_float::from_chars(value.data(),
78+
value.data() + value.size(),
79+
converted_value); // NOLINT -- Trying to iterators on the value causes the test to infinitly hang on windows builds
7880
return converted_value;
7981
}
8082

0 commit comments

Comments
 (0)