Skip to content

Commit 58f485e

Browse files
committed
Require bracing on single line if statements using clang format
1 parent af79962 commit 58f485e

File tree

4 files changed

+48
-24
lines changed

4 files changed

+48
-24
lines changed

.clang-format

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ BraceWrapping:
4444
AfterClass: false
4545
AfterCaseLabel: false
4646

47+
InsertBraces: true
48+
4749
# CrlInstruction *a;
4850
DerivePointerAlignment: false
4951
PointerAlignment: Left

src/dbc.cpp

Lines changed: 37 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,25 @@ bool parseVal(const std::string& str, VALObject& obj) {
4343
for (;;) {
4444
switch (state) {
4545
case Identifier: {
46-
if (*a != 'V')
46+
if (*a != 'V') {
4747
return false;
48+
}
4849
a++;
49-
if (*a != 'A')
50+
if (*a != 'A') {
5051
return false;
52+
}
5153
a++;
52-
if (*a != 'L')
54+
if (*a != 'L') {
5355
return false;
56+
}
5457
a++;
55-
if (*a != '_')
58+
if (*a != '_') {
5659
return false;
60+
}
5761
a++;
58-
if (*a != ' ')
62+
if (*a != ' ') {
5963
return false;
64+
}
6065
a++; // skip whitespace
6166
state = CANId;
6267
break;
@@ -67,27 +72,31 @@ bool parseVal(const std::string& str, VALObject& obj) {
6772
can_id_str += *a;
6873
a++;
6974
}
70-
if (can_id_str.empty())
75+
if (can_id_str.empty()) {
7176
return false;
77+
}
7278
obj.can_id = static_cast<uint32_t>(std::stoul(can_id_str));
73-
if (*a != ' ')
79+
if (*a != ' ') {
7480
return false;
81+
}
7582
a++; // skip whitespace
7683
state = SignalName;
7784
break;
7885
}
7986
case SignalName: {
80-
if ((*a >= 'a' && *a <= 'z') || (*a >= 'A' && *a <= 'Z') || *a == '_')
87+
if ((*a >= 'a' && *a <= 'z') || (*a >= 'A' && *a <= 'Z') || *a == '_') {
8188
obj.signal_name += *a;
82-
else
89+
} else {
8390
return false;
91+
}
8492
a++;
8593
while ((*a >= 'a' && *a <= 'z') || (*a >= 'A' && *a <= 'Z') || *a == '_' || (*a >= '0' && *a <= '9')) {
8694
obj.signal_name += *a;
8795
a++;
8896
}
89-
if (*a != ' ')
97+
if (*a != ' ') {
9098
return false;
99+
}
91100
a++; // skip whitespace
92101
state = Value;
93102
break;
@@ -99,34 +108,40 @@ bool parseVal(const std::string& str, VALObject& obj) {
99108
a++;
100109
}
101110
if (*a == ';') {
102-
if (value_str.empty())
111+
if (value_str.empty()) {
103112
return true;
113+
}
104114
return false;
105115
}
106-
if (value_str.empty())
116+
if (value_str.empty()) {
107117
return false;
118+
}
108119

109-
if (*a != ' ')
120+
if (*a != ' ') {
110121
return false;
122+
}
111123
a++; // skip whitespace
112124
vd.value = (uint32_t)std::stoul(value_str);
113125
state = Description;
114126
break;
115127
}
116128
case Description: {
117129
std::string desc;
118-
if (*a != '"')
130+
if (*a != '"') {
119131
return false;
132+
}
120133
a++;
121134
while (*a != '"' && *a != 0) {
122135
desc += *a;
123136
a++;
124137
}
125-
if (*a == 0)
138+
if (*a == 0) {
126139
return false;
140+
}
127141
a++;
128-
if (*a != ' ')
142+
if (*a != ' ') {
129143
return false;
144+
}
130145
a++; // skip whitespace
131146

132147
vd.description = desc;
@@ -188,8 +203,9 @@ std::vector<libdbc::Message> DbcParser::get_messages() const {
188203

189204
Message::ParseSignalsStatus DbcParser::parseMessage(const uint32_t id, const std::vector<uint8_t>& data, std::vector<double>& out_values) {
190205
for (const auto& message : messages) {
191-
if (message.id() == id)
206+
if (message.id() == id) {
192207
return message.parseSignals(data, out_values);
208+
}
193209
}
194210
return Message::ParseSignalsStatus::ErrorUnknownID;
195211
}
@@ -212,8 +228,9 @@ void DbcParser::parse_dbc_header(std::istream& file_stream) {
212228

213229
utils::StreamHandler::get_next_non_blank_line(file_stream, line);
214230

215-
if (!std::regex_search(line, match, bit_timing_re))
231+
if (!std::regex_search(line, match, bit_timing_re)) {
216232
throw validity_error();
233+
}
217234
}
218235

219236
void DbcParser::parse_dbc_nodes(std::istream& file_stream) {
@@ -222,8 +239,9 @@ void DbcParser::parse_dbc_nodes(std::istream& file_stream) {
222239

223240
utils::StreamHandler::get_next_non_blank_line(file_stream, line);
224241

225-
if (!std::regex_search(line, match, node_re))
242+
if (!std::regex_search(line, match, node_re)) {
226243
throw validity_error();
244+
}
227245

228246
if (match.length() > 2) {
229247
std::string n = match.str(2);

src/message.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ bool Message::operator==(const Message& rhs) const {
1616

1717
Message::ParseSignalsStatus Message::parseSignals(const std::vector<uint8_t>& data, std::vector<double>& values) const {
1818
auto size = data.size();
19-
if (size > 8)
19+
if (size > 8) {
2020
return ParseSignalsStatus::ErrorMessageToLong; // not supported yet
21+
}
2122

2223
uint64_t data_little_endian = 0;
2324
uint64_t data_big_endian = 0;
@@ -35,8 +36,9 @@ Message::ParseSignalsStatus Message::parseSignals(const std::vector<uint8_t>& da
3536
uint32_t start_bit = 8 * (signal.start_bit / 8) + (7 - (signal.start_bit % 8)); // Calculation taken from python CAN
3637
v = data_big_endian << start_bit;
3738
v = v >> (len - signal.size);
38-
} else
39+
} else {
3940
v = data_little_endian >> signal.start_bit;
41+
}
4042

4143
if (signal.is_signed && signal.size > 1) {
4244
switch (signal.size) {
@@ -56,10 +58,11 @@ Message::ParseSignalsStatus Message::parseSignals(const std::vector<uint8_t>& da
5658
// 2 complement -> decimal
5759
const int negative = (v & (1ull << (signal.size - 1))) != 0;
5860
int64_t nativeInt;
59-
if (negative)
61+
if (negative) {
6062
nativeInt = static_cast<int64_t>(v | ~((1ull << signal.size) - 1)); // invert all bits above signal.size
61-
else
63+
} else {
6264
nativeInt = static_cast<int64_t>(v & ((1ull << signal.size) - 1)); // masking
65+
}
6366
values.push_back(static_cast<double>(nativeInt) * signal.factor + signal.offset);
6467
break;
6568
}

src/signal.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ std::ostream& operator<<(std::ostream& out, const Signal& sig) {
4747
out << "Min: " << sig.min << ", Max: " << sig.max << ", ";
4848
out << "Unit: (" << sig.unit << "), ";
4949
out << "receivers: ";
50-
for (const auto& r : sig.receivers)
50+
for (const auto& r : sig.receivers) {
5151
out << r;
52+
}
5253
return out << "}";
5354
}
5455
}

0 commit comments

Comments
 (0)