Skip to content

Commit 120927a

Browse files
committed
fix: Adding include checks in clang-tidy and fixing all the issues
1 parent 089c1e5 commit 120927a

File tree

9 files changed

+26
-16
lines changed

9 files changed

+26
-16
lines changed

.clang-tidy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-*,clang-analyzer-cplusplus*,cert-*,cppcoreguidelines-*,portability-*,readability-*,clang-diagnostic-*'
2+
Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,clang-analyzer-*,clang-analyzer-cplusplus*,cert-*,cppcoreguidelines-*,portability-*,readability-*,clang-diagnostic-*,misc-include-cleaner'
33
WarningsAsErrors: ''
44
HeaderFilterRegex: ''
55
AnalyzeTemporaryDtors: false

include/libdbc/dbc.hpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
#ifndef DBC_HPP
22
#define DBC_HPP
33

4-
#include <libdbc/exceptions/error.hpp>
5-
#include <libdbc/message.hpp>
6-
#include <libdbc/signal.hpp>
7-
#include <libdbc/utils/utils.hpp>
8-
4+
#include <cstdint>
95
#include <regex>
6+
#include <string>
7+
#include <vector>
8+
#include <istream>
9+
#include <libdbc/message.hpp>
1010

1111
namespace Libdbc {
1212

include/libdbc/message.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#ifndef MESSAGE_HPP
22
#define MESSAGE_HPP
33

4-
#include <array>
54
#include <iostream>
65
#include <libdbc/signal.hpp>
76
#include <string>
87
#include <vector>
8+
#include <cstdint>
99

1010
namespace Libdbc {
1111
struct Message {

include/libdbc/utils/utils.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22
#ifndef UTILS_HPP
33
#define UTILS_HPP
44

5-
#include <algorithm>
6-
#include <fstream>
75
#include <iostream>
8-
#include <iterator>
96
#include <sstream>
107
#include <string>
118

src/dbc.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
#include <cstdint>
2+
#include <fstream>
3+
#include <istream>
24
#include <libdbc/dbc.hpp>
35
#include <libdbc/exceptions/error.hpp>
6+
#include <libdbc/message.hpp>
7+
#include <libdbc/signal.hpp>
48
#include <libdbc/utils/utils.hpp>
5-
69
#include <regex>
10+
#include <string>
711
#include <vector>
812

913
namespace Libdbc {

src/message.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
1+
#include <cstddef>
12
#include <cstdint>
23
#include <libdbc/message.hpp>
4+
#include <libdbc/signal.hpp>
5+
#include <ostream>
6+
#include <string>
7+
#include <vector>
38

49
namespace Libdbc {
510

@@ -29,7 +34,7 @@ Message::ParseSignalsStatus Message::parse_signals(const std::vector<uint8_t>& d
2934

3035
uint64_t data_little_endian = 0;
3136
uint64_t data_big_endian = 0;
32-
for (size_t i = 0; i < size; i++) {
37+
for (std::size_t i = 0; i < size; i++) {
3338
data_little_endian |= ((uint64_t)data[i]) << i * ONE_BYTE;
3439
data_big_endian = (data_big_endian << ONE_BYTE) | (uint64_t)data[i];
3540
}

src/signal.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1+
#include <cstdint>
12
#include <libdbc/signal.hpp>
3+
#include <ostream>
4+
#include <string>
5+
#include <vector>
26

37
namespace Libdbc {
48
Signal::Signal(std::string name,

src/utils.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
#include <charconv>
2-
#include <exception>
1+
#include <cstddef>
32
#include <fast_float/fast_float.h>
3+
#include <istream>
44
#include <libdbc/utils/utils.hpp>
5-
65
#include <regex>
6+
#include <string>
77

88
namespace Utils {
99

test/test_utils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "testing_utils/defines.hpp"
22
#include <catch2/catch_test_macros.hpp>
3+
#include <fstream>
34
#include <libdbc/utils/utils.hpp>
4-
55
#include <sstream>
66

77
namespace Utils {

0 commit comments

Comments
 (0)