Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Nov 5, 2025

What does this PR do?

Update ruff target version to Python 3.10 as part of #21304

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21334.org.readthedocs.build/en/21334/

@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package has conflicts labels Nov 5, 2025
@Borda Borda force-pushed the update-pyproject-py310 branch from 38b7936 to e052da7 Compare November 7, 2025 10:18
@SkafteNicki
Copy link
Collaborator

@matsumotosan I think #21344 needs to be merged before tests can pass for this PR

@matsumotosan
Copy link
Contributor Author

@SkafteNicki I agree. I figured I could take a look at the changes the linter would make since it would be a lot.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 98.70436% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (b15d394) to head (0e4ed01).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21334   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23744    23746    +2     
=======================================
- Hits        20572    20571    -1     
- Misses       3172     3175    +3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants