fix serving raw body bytes

Author: saviorand

external/libc.mojo

@@ -85,7 +85,6 @@ fn to_char_ptr(s: String) -> UnsafePointer[c_char]:
         ptr[i] = ord(s[i])
     return ptr
 
-
 fn to_char_ptr(s: Bytes) -> UnsafePointer[c_char]:
     var ptr = UnsafePointer[c_char]().alloc(len(s))
     for i in range(len(s)):

lightbug_http/http.mojo

@@ -211,6 +211,9 @@ struct HTTPResponse(Response):
     fn get_body_bytes(self) -> BytesView:
         return BytesView(unsafe_ptr=self.body_raw.unsafe_ptr(), len=self.body_raw.size)
 
+    fn get_body(self) -> Bytes:
+        return self.body_raw
+
     fn set_body_bytes(inout self, body: Bytes) -> Self:
         self.body_raw = body
         return self
@@ -328,7 +331,7 @@ fn encode(req: HTTPRequest) raises -> StringSlice[False, ImmutableStaticLifetime
     return StringSlice[False, ImmutableStaticLifetime](unsafe_from_utf8_ptr=builder.render().unsafe_ptr(), len=builder.size)
 
 
-fn encode(res: HTTPResponse) raises -> String:
+fn encode(res: HTTPResponse) raises -> Bytes:
     var current_time = String()
     try:
         current_time = Morrow.utcnow().__str__()
@@ -392,8 +395,8 @@ fn encode(res: HTTPResponse) raises -> String:
 
     if len(res.body_raw) > 0:
         _ = builder.write(res.get_body_bytes())
-
-    return StringSlice[False, ImmutableStaticLifetime](unsafe_from_utf8_ptr=builder.render().unsafe_ptr(), len=builder.size)
+    
+    return builder.render().as_bytes_slice()
 
 fn split_http_string(buf: Bytes) raises -> (String, String, String):
     var request = String(buf)

lightbug_http/sys/server.mojo

@@ -219,13 +219,6 @@ struct SysServer:
             except e:
                 error = Error("Failed to read request body: " + e.__str__())
 
-            # var remaining_body = Bytes()
-            # var remaining_len = header.content_length() - (len(request_body) + 1)
-            # while remaining_len > 0:
-            #     var read_len = conn.read(remaining_body)
-            #     buf.extend(remaining_body)
-            #     remaining_len -= read_len
-            
             var res = handler.func(request)
 
             if not self.tcp_keep_alive:

tests/test_http.mojo

@@ -54,12 +54,12 @@ def test_encode_http_response():
     var expected_full = "HTTP/1.1 200 OK\r\nServer: lightbug_http\r\nContent-Type: application/octet-stream\r\nContent-Length: 13\r\nConnection: keep-alive\r\nDate: 2024-06-02T13:41:50.766880+00:00\r\n\r\nHello, World!"
 
     var expected_headers_len = 124
-    var hello_world_len = len(String("Hello, World!"))
+    var hello_world_len = len(String("Hello, World!")) - 1 # -1 for the null terminator
     var date_header_len = len(String("Date: 2024-06-02T13:41:50.766880+00:00"))
 
     var expected_split = String(expected_full).split("\r\n\r\n")
     var expected_headers = expected_split[0]
     var expected_body = expected_split[1]
-
+    
     test.assert_equal(res_str[:expected_headers_len], expected_headers[:len(expected_headers) - date_header_len])
-    test.assert_equal(res_str[(len(res_str) - hello_world_len):len(res_str)], expected_body)
+    test.assert_equal(res_str[(len(res_str) - hello_world_len):len(res_str) + 1], expected_body)