Skip to content

Commit 90e6998

Browse files
committed
removed __del__ from connection and listener
1 parent 32ca13a commit 90e6998

File tree

1 file changed

+6
-22
lines changed

1 file changed

+6
-22
lines changed

lightbug_http/net.mojo

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,6 @@ struct NoTLSListener:
114114
fn __moveinit__(out self, owned existing: Self):
115115
self.socket = existing.socket^
116116

117-
fn __enter__(owned self) -> Self:
118-
return self^
119-
120-
fn __del__(owned self):
121-
try:
122-
self.socket.teardown()
123-
except e:
124-
logger.debug("NoTLSListener.__del__: Failed to close socket on deletion:", e)
125-
126117
fn accept(self) raises -> TCPConnection:
127118
return TCPConnection(self.socket.accept())
128119

@@ -156,14 +147,13 @@ struct ListenConfig:
156147
logger.error(e)
157148
raise Error("ListenConfig.listen: Failed to create listener due to socket creation failure.")
158149

159-
try:
160-
161-
@parameter
162-
# TODO: do we want to reuse port on linux? currently doesn't work
163-
if os_is_macos():
150+
@parameter
151+
# TODO: do we want to reuse port on linux? currently doesn't work
152+
if os_is_macos():
153+
try:
164154
socket.set_socket_option(SO_REUSEADDR, 1)
165-
except e:
166-
logger.warn("ListenConfig.listen: Failed to set socket as reusable", e)
155+
except e:
156+
logger.warn("ListenConfig.listen: Failed to set socket as reusable", e)
167157

168158
var bind_success = False
169159
var bind_fail_logged = False
@@ -208,12 +198,6 @@ struct TCPConnection:
208198
fn __moveinit__(out self, owned existing: Self):
209199
self.socket = existing.socket^
210200

211-
fn __del__(owned self):
212-
try:
213-
self.socket.teardown()
214-
except e:
215-
logger.debug("TCPConnection.__del__: Failed to close socket on deletion:", e)
216-
217201
fn read(self, mut buf: Bytes) raises -> Int:
218202
try:
219203
return self.socket.receive(buf)

0 commit comments

Comments
 (0)