Skip to content

Commit f92a718

Browse files
authored
Merge pull request #332 from MTeresaMB/feature/#320-resolve-experience-links
Closed #332
2 parents 2aa10ce + d0e2bd7 commit f92a718

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

packages/manfred2html/src/engine/cv-x-wing-squadron/html-parts/experience-section/experience-section.ejs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<p><%- new Date(experience.roles[0].startDate).toLocaleDateString(undefined, { year:"numeric", month:"short"})%> <%_ if(experience.roles[0].finishDate && experience.roles[0].finishDate.toLowerCase() !=='actualidad') { -%>
2525
<%- "- "+new Date(experience.roles[0].finishDate).toLocaleDateString(undefined, { year:"numeric", month:"short"}) -%>
2626
<%_ } else { -%>
27-
- Actualidad
27+
- <%= labels.CURRENT_DATE %>
2828
<%_}-%>
2929
</p>
3030
</div>
@@ -40,9 +40,11 @@
4040
</ul>
4141
<%_ } -%>
4242
</div>
43-
<a href="<%= experience.URL %>" target="_blank"><%= experience.name %></a>
43+
<%_ if(experience.URL) { -%>
44+
<a href="<%= experience.URL %>" target="_blank"><%= experience.name %></a>
45+
<%_ } -%>
4446
<%_ if (experience.roles[0].competences && experience.roles[0].competence !== 0) { -%>
45-
<h3 class="tech__tools__heading">Tecnologías y Herramientas</h3>
47+
<h3 class="tech__tools__heading"><%= labels.TECH_TOOLS_HEADING %></h3>
4648
<ul class="ul__technologies">
4749
<%_ for(const competence of experience.roles[0].competences) { -%>
4850
<li class="li__technologies"><%= competence.name %></li>

packages/manfred2html/src/engine/cv-x-wing-squadron/html-parts/experience-section/labels/experience-english-labels.const.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ import { ExperienceLabels } from './experience-label.model';
22

33
export const englishExperienceLabels: ExperienceLabels = {
44
EXPERIENCE_CAREER_HEADING: 'Experience / Career',
5+
TECH_TOOLS_HEADING: 'Technologies and Tools',
6+
CURRENT_DATE: 'Now',
57
};
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
export interface ExperienceLabels {
22
EXPERIENCE_CAREER_HEADING: string;
3+
TECH_TOOLS_HEADING: string;
4+
CURRENT_DATE: string;
35
}

packages/manfred2html/src/engine/cv-x-wing-squadron/html-parts/experience-section/labels/experience-spanish-labels.const.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ import { ExperienceLabels } from './experience-label.model';
22

33
export const spanishExperienceLabels: ExperienceLabels = {
44
EXPERIENCE_CAREER_HEADING: 'Experiencia / Carrera',
5+
TECH_TOOLS_HEADING: 'Tecnologias y Herramientas',
6+
CURRENT_DATE: 'Actualidad',
57
};

0 commit comments

Comments
 (0)