Skip to content

Commit 28f44fe

Browse files
committed
create label for current date, delete undefined and fix link
1 parent 8b51094 commit 28f44fe

File tree

8 files changed

+10
-5
lines changed

8 files changed

+10
-5
lines changed

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.ejs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div class="experience">
77
<p class="experience__date"><%- new Date(experience.roles[0].startDate).toLocaleDateString(undefined, { year:"numeric", month:"short"})%> <%_ if(experience.roles[0].finishDate && experience.roles[0].finishDate.toLowerCase() !=='actualidad') { -%>
88
<%- "- "+new Date(experience.roles[0].finishDate).toLocaleDateString(undefined, { year:"numeric", month:"short"}) -%>
9-
<%_ } else { -%> - Actualidad<%_}-%></p>
9+
<%_ } else { -%> - <%- labels.CURRENT_DATE %> <%_ } -%>
1010
<h3 class="experience__position"><%- experience.roles[0].name %></h3>
1111
<h4 class="experience__company"><%- experience.name %></h4>
1212
<%_ if(experience.roles[0].challenges && experience.roles[0].challenges.length !== 0) { -%>
@@ -16,8 +16,8 @@
1616
<%_}-%>
1717
</div>
1818
<%_}-%>
19-
<%_ if(experience.url && experience.url !== "undefined") { -%>
20-
<a href="https://www.getmanfred.com" class="experience__url" target="_blank"><%- experience.url %></a>
19+
<%_ if(experience.url) { -%>
20+
<a href=<%= experience.url %> class="experience__url" target="_blank"><%- experience.url %></a>
2121
<%_}-%>
2222
<%_ if(experience.roles[0].competences && experience.roles[0].competences.length !== 0) { -%>
2323
<div>

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/labels/experience-english-labels.const.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ import { ExperienceLabels } from './experience-label.model';
33
export const englishExperienceLabels: ExperienceLabels = {
44
EXPERIENCE_CAREER_HEADING: 'Experience / Career',
55
EXPERIENCE_CAREER_TOOLS: 'Technologies and Tools',
6+
CURRENT_DATE: 'Now',
67
};
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
export interface ExperienceLabels {
22
EXPERIENCE_CAREER_HEADING: string;
33
EXPERIENCE_CAREER_TOOLS: string;
4+
CURRENT_DATE: string;
45
}

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/labels/experience-spanish-labels.const.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ import { ExperienceLabels } from './experience-label.model';
33
export const spanishExperienceLabels: ExperienceLabels = {
44
EXPERIENCE_CAREER_HEADING: 'Experiencia / Carrera',
55
EXPERIENCE_CAREER_TOOLS: 'Tecnologías y Herramientas',
6+
CURRENT_DATE: 'Actualidad',
67
};

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/studies-section/labels/studies-english-labels.const.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ import { StudiesLabels } from './studies-label.model';
22

33
export const englishStudiesLabels: StudiesLabels = {
44
STUDIES_HEADING: 'Studies',
5+
CURRENT_DATE: 'Now',
56
};
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
export interface StudiesLabels {
22
STUDIES_HEADING: string;
3+
CURRENT_DATE: string;
34
}

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/studies-section/labels/studies-spanish-labels.const.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ import { StudiesLabels } from './studies-label.model';
22

33
export const spanishStudiesLabels: StudiesLabels = {
44
STUDIES_HEADING: 'Estudios',
5+
CURRENT_DATE: 'Actualidad',
56
};

packages/manfred2html/src/engine/cv-monochrome-force/html-parts/studies-section/studies-section.ejs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
<div class="education__group">
1111
<p class="education__date"><%- new Date(study.startDate).toLocaleDateString(undefined, { year:"numeric", month:"short"})%> <%_ if(study.finishDate && study.finishDate.toLowerCase() !=='actualidad') { -%>
1212
<%- "- "+new Date(study.finishDate).toLocaleDateString(undefined, { year:"numeric", month:"short"}) -%>
13-
<%_ } else { -%> - Actualidad
14-
<%_}-%>
13+
<%_ } else { -%> - <%- labels.CURRENT_DATE %> <%_ } -%>
1514
</p>
1615
<p class="education__title"><%- study.name %></p>
1716
<p class="education__entity"><%- study.institution.name %></p>

0 commit comments

Comments
 (0)