Merge pull request #339 from LeetCode-OpenSource/fix/many-issues

fix: higher deps version issues

Author: Miloas

.github/workflows/main.yml

@@ -28,6 +28,8 @@ jobs:
         with:
           node-version: 14
       - run: npm install
+      - run: npm install yarn -g
+      - run: yarn lint
       - run: npm run build
       - id: publish
         uses: JS-DevTools/npm-publish@v1

package.json

@@ -18,6 +18,7 @@
   "scripts": {
     "build": "rm -rf ./dist && tsc -p ./tsconfig.json",
     "lint": "yarn lint:eslint && yarn lint:tsc",
+    "lint:tsc": "tsc -p ./tsconfig.json --noEmit",
     "lint:eslint": "eslint . --ext .ts,.tsx --fix --max-warnings 0"
   },
   "keywords": [
@@ -58,15 +59,15 @@
   },
   "dependencies": {
     "chalk": "^4.0.0",
-    "commander": "^7.0.0",
+    "commander": "^6.0.0",
     "glob": "^7.1.3",
     "js-yaml": "^4.0.0",
     "lodash": "^4.17.11",
     "log-update": "^4.0.0",
     "outdent": "^0.8.0",
-    "path-to-regexp": "^6.1.0",
+    "path-to-regexp": "^3.0.0",
     "prettier": "^2.0.1",
     "qs": "^6.6.0",
-    "tslib": "^2.0.0"
+    "tslib": "^2.1.0"
   }
 }

src/cli/index.ts

@@ -1,7 +1,7 @@
 import * as fs from 'fs'
 import * as path from 'path'
-import * as program from 'commander'
-import * as glob from 'glob'
+import program from 'commander'
+import glob from 'glob'
 import outdent from 'outdent'
 import chalk from 'chalk'
 import { format, resolveConfig } from 'prettier'

src/cli/utils.ts

@@ -1,6 +1,6 @@
 import { merge } from 'lodash'
-import { safeLoad } from 'js-yaml'
-import * as pathToRegexp from 'path-to-regexp'
+import { load } from 'js-yaml'
+import pathToRegexp from 'path-to-regexp'
 
 import { ParamsType } from '../path-utils'
 import { Options, YAML } from './types'
@@ -43,7 +43,7 @@ export function codeStringify(code: Record<string, unknown>): string {
 }
 
 export function loadYAML(yaml: string): YAML {
-  const { paths = {}, options = {} } = safeLoad(yaml)
+  const { paths = {}, options = {} } = load(yaml) as any
 
   return {
     paths,

tsconfig.json

@@ -11,6 +11,7 @@
     "noImplicitAny": true,
     "strict": true,
     "noImplicitReturns": true,
+    "esModuleInterop": true,
     "moduleResolution": "node",
     "lib": ["dom", "es2015"],
     "target": "es5",

yarn.lock

@@ -369,16 +369,11 @@ color-name@~1.1.4:
   resolved "https://npm.lingkou.xyz/color-name/-/color-name-1.1.4.tgz#c2a09a87acbde69543de6f63fa3995c826c536a2"
   integrity sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==
 
-commander@^6.2.0:
+commander@^6.0.0, commander@^6.2.0:
   version "6.2.1"
   resolved "https://npm.lingkou.xyz/commander/-/commander-6.2.1.tgz#0792eb682dfbc325999bb2b84fddddba110ac73c"
   integrity sha1-B5LraC37wyWZm7K4T93duhEKxzw=
 
-commander@^7.0.0:
-  version "7.2.0"
-  resolved "https://npm.lingkou.xyz/commander/-/commander-7.2.0.tgz#a36cb57d0b501ce108e4d20559a150a391d97ab7"
-  integrity sha1-o2y1fQtQHOEI5NIFWaFQo5HZerc=
-
 concat-map@0.0.1:
   version "0.0.1"
   resolved "https://npm.lingkou.xyz/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
@@ -1112,10 +1107,10 @@ path-key@^3.0.0, path-key@^3.1.0:
   resolved "https://npm.lingkou.xyz/path-key/-/path-key-3.1.1.tgz#581f6ade658cbba65a0d3380de7753295054f375"
   integrity sha512-ojmeN0qd+y0jszEtoY48r0Peq5dwMEkIlCOu6Q5f41lfkswXuKtYrhgoTpLnyIcHm24Uhqx+5Tqm2InSwLhE6Q==
 
-path-to-regexp@^6.1.0:
-  version "6.2.0"
-  resolved "https://npm.lingkou.xyz/path-to-regexp/-/path-to-regexp-6.2.0.tgz#f7b3803336104c346889adece614669230645f38"
-  integrity sha1-97OAMzYQTDRoia3s5hRmkjBkXzg=
+path-to-regexp@^3.0.0:
+  version "3.2.0"
+  resolved "https://npm.lingkou.xyz/path-to-regexp/-/path-to-regexp-3.2.0.tgz#fa7877ecbc495c601907562222453c43cc204a5f"
+  integrity sha1-+nh37LxJXGAZB1YiIkU8Q8wgSl8=
 
 path-type@^4.0.0:
   version "4.0.0"