Skip to content

bugfix(env): fix accumulate batches, gpu list #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bugfix(env): fix accumulate batches, gpu list #65

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65742da
bugfix(env): fix accumulate batches, gpu list, and python/bash mixing
megatran Jun 23, 2023
d21b142
bugfix(env): fix accumulate batches, gpu list, and python/bash mixing
megatran Jun 23, 2023
43e80a5
Revert "bugfix(env): fix accumulate batches, gpu list, and python/bas…
megatran Jun 23, 2023
2508f36
bugfix(env): fix accumulate batches, gpu list
megatran Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions stable-diffusion-finetuning/pokemon_finetune.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"cells": [
{
"attachments": {},
"cell_type": "markdown",
"metadata": {
"id": "ipSgY-L3z8kG"
Expand Down Expand Up @@ -59,6 +60,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {
"id": "5V1uUVjQz8kI"
Expand Down Expand Up @@ -94,6 +96,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"metadata": {
"id": "y8VDyuQxz8kJ"
Expand All @@ -118,9 +121,21 @@
"BATCH_SIZE = 4\n",
"N_GPUS = 2\n",
"ACCUMULATE_BATCHES = 1\n",
"GPU_LIST = \",\".join((str(x) for x in range(N_GPUS))) + \",\"\n",
"print(f\"Using GPUs: {GPU_LIST}\")\n",
"\n",
"gpu_list = \",\".join((str(x) for x in range(N_GPUS))) + \",\"\n",
"print(f\"Using GPUs: {gpu_list}\")"
"import os\n",
"os.environ[\"BATCH_SIZE\"] = str(BATCH_SIZE) \n",
"os.environ[\"N_GPUS\"] = str(N_GPUS) \n",
"os.environ[\"ACCUMULATE_BATCHES\"] = str(ACCUMULATE_BATCHES)\n",
"os.environ[\"GPU_LIST\"] = GPU_LIST\n",
"os.environ[\"CKPT_PATH\"] = ckpt_path\n",
"\n",
"!echo \"$BATCH_SIZE\"\n",
"!echo \"$N_GPUS\"\n",
"!echo \"$ACCUMULATE_BATCHES\"\n",
"!echo \"$GPU_LIST\"\n",
"!echo \"$CKPT_PATH\""
]
},
{
Expand All @@ -135,14 +150,14 @@
"!(python main.py \\\n",
" -t \\\n",
" --base configs/stable-diffusion/pokemon.yaml \\\n",
" --gpus \"$gpu_list\" \\\n",
" --gpus \"$GPU_LIST\" \\\n",
" --scale_lr False \\\n",
" --num_nodes 1 \\\n",
" --check_val_every_n_epoch 10 \\\n",
" --finetune_from \"$ckpt_path\" \\\n",
" --finetune_from \"$CKPT_PATH\" \\\n",
" data.params.batch_size=\"$BATCH_SIZE\" \\\n",
" lightning.trainer.accumulate_grad_batches=\"$ACCUMULATE_BATCHES\" \\\n",
" data.params.validation.params.n_gpus=\"$NUM_GPUS\" \\\n",
" data.params.validation.params.n_gpus=\"$N_GPUS\" \\\n",
")"
]
},
Expand Down