File tree Expand file tree Collapse file tree 2 files changed +6
-11
lines changed Expand file tree Collapse file tree 2 files changed +6
-11
lines changed Original file line number Diff line number Diff line change @@ -194,7 +194,7 @@ def export_issues(self, status=None):
194194 }
195195 }""" % (id_param , status_param , id_param , status_param )
196196
197- valid_statuses = [ None , "Open" , "Resolved" ]
197+ valid_statuses = { None , "Open" , "Resolved" }
198198
199199 if status not in valid_statuses :
200200 raise ValueError ("status must be in {}. Found {}" .format (
Original file line number Diff line number Diff line change 33
44def test_issues_export (project ):
55 exported_issues_url = project .export_issues ()
6- assert exported_issues_url is not None
7- assert exported_issues_url is not ''
6+ assert exported_issues_url
87
98 exported_issues_url = project .export_issues ("Open" )
10- assert exported_issues_url is not None
11- assert exported_issues_url is not ''
9+ assert exported_issues_url
1210 assert "?status=Open" in exported_issues_url
1311
1412 exported_issues_url = project .export_issues ("Resolved" )
15- assert exported_issues_url is not None
16- assert exported_issues_url is not ''
13+ assert exported_issues_url
1714 assert "?status=Resolved" in exported_issues_url
1815
1916 invalidStatusValue = "Closed"
2017 with pytest .raises (ValueError ) as exc_info :
2118 exported_issues_url = project .export_issues (invalidStatusValue )
22- assert str (
23- exc_info .value
24- ) == "status must be in [None, 'Open', 'Resolved']. Found {}" .format (
25- invalidStatusValue )
19+ assert "status must be in" in str (exc_info .value )
20+ assert "Found %s" % (invalidStatusValue ) in str (exc_info .value )
You can’t perform that action at this time.
0 commit comments