Skip to content

Commit f1955fb

Browse files
author
Rodion Yaryy
committed
Address feedback
- Adjust test cases - change valid statuses variable from list to set
1 parent c53ce93 commit f1955fb

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

labelbox/schema/project.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def export_issues(self, status=None):
194194
}
195195
}""" % (id_param, status_param, id_param, status_param)
196196

197-
valid_statuses = [None, "Open", "Resolved"]
197+
valid_statuses = {None, "Open", "Resolved"}
198198

199199
if status not in valid_statuses:
200200
raise ValueError("status must be in {}. Found {}".format(

tests/integration/test_issues.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,18 @@
33

44
def test_issues_export(project):
55
exported_issues_url = project.export_issues()
6-
assert exported_issues_url is not None
7-
assert exported_issues_url is not ''
6+
assert exported_issues_url
87

98
exported_issues_url = project.export_issues("Open")
10-
assert exported_issues_url is not None
11-
assert exported_issues_url is not ''
9+
assert exported_issues_url
1210
assert "?status=Open" in exported_issues_url
1311

1412
exported_issues_url = project.export_issues("Resolved")
15-
assert exported_issues_url is not None
16-
assert exported_issues_url is not ''
13+
assert exported_issues_url
1714
assert "?status=Resolved" in exported_issues_url
1815

1916
invalidStatusValue = "Closed"
2017
with pytest.raises(ValueError) as exc_info:
2118
exported_issues_url = project.export_issues(invalidStatusValue)
22-
assert str(
23-
exc_info.value
24-
) == "status must be in [None, 'Open', 'Resolved']. Found {}".format(
25-
invalidStatusValue)
19+
assert "status must be in" in str(exc_info.value)
20+
assert "Found %s" % (invalidStatusValue) in str(exc_info.value)

0 commit comments

Comments
 (0)