Skip to content

Commit e4bac5a

Browse files
authored
Merge pull request #332 from Labelbox/DIAG-889
updates to tests after implementation of LabelImport
2 parents d7d495a + f7c0ebb commit e4bac5a

File tree

3 files changed

+6
-24
lines changed

3 files changed

+6
-24
lines changed

tests/integration/annotation_import/test_label_import.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ def test_get(client, project, annotation_import_test_helpers):
6666

6767

6868
@pytest.mark.slow
69-
@pytest.mark.skip(reason="beta feature still being developed")
7069
def test_wait_till_done(client, project, predictions):
7170
name = str(uuid.uuid4())
7271
label_import = LabelImport.create_from_objects(client=client,
@@ -76,19 +75,13 @@ def test_wait_till_done(client, project, predictions):
7675

7776
assert len(label_import.inputs) == len(predictions)
7877
label_import.wait_until_done()
79-
# TODO(grant): some of this is commented out
80-
# TODO(grant): since the pipeline is not complete, you will get a failed status
8178

82-
# assert label_import.state == AnnotationImportState.FINISHED
83-
# # Check that the status files are being returned as expected
84-
# assert len(label_import.errors) == 0
79+
assert label_import.state == AnnotationImportState.FINISHED
8580
assert len(label_import.inputs) == len(predictions)
8681
input_uuids = [input_annot['uuid'] for input_annot in label_import.inputs]
8782
inference_uuids = [pred['uuid'] for pred in predictions]
8883
assert set(input_uuids) == set(inference_uuids)
8984
assert len(label_import.statuses) == len(predictions)
90-
# for status in label_import.statuses:
91-
# assert status['status'] == 'SUCCESS'
9285
status_uuids = [
9386
input_annot['uuid'] for input_annot in label_import.statuses
9487
]

tests/integration/test_label.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
from labelbox import Label
88

99

10-
@pytest.mark.skip("Cannot query for labels created with create_label")
1110
def test_labels(label_pack):
1211
project, dataset, data_row, label = label_pack
1312

@@ -30,20 +29,14 @@ def test_labels(label_pack):
3029
assert list(data_row.labels()) == []
3130

3231

33-
def test_label_export(client, label_pack):
34-
project, dataset, data_row, label = label_pack
35-
#Project has to be setup for export to be possible
36-
editor = list(
37-
client.get_labeling_frontends(
38-
where=LabelingFrontend.name == "editor"))[0]
39-
empty_ontology = {"tools": [], "classifications": []}
40-
project.setup(editor, empty_ontology)
41-
project.create_label(data_row=data_row, label="export_label")
32+
def test_label_export(client, configured_project_with_label):
33+
project, label_id = configured_project_with_label
34+
4235
exported_labels_url = project.export_labels()
4336
assert exported_labels_url is not None
4437
exported_labels = requests.get(exported_labels_url)
45-
labels = [example['Label'] for example in exported_labels.json()]
46-
#assert 'export_label' in labels
38+
labels = [example['ID'] for example in exported_labels.json()]
39+
assert labels[0] == label_id
4740
# TODO: Add test for bulk export back.
4841
# The new exporter doesn't work with the create_label mutation
4942

@@ -54,7 +47,6 @@ def test_label_update(label_pack):
5447
assert label.label == "something else"
5548

5649

57-
@pytest.mark.skip("Cannot query for labels created with create_label")
5850
def test_label_filter_order(client, project, rand_gen, image_url):
5951
dataset_1 = client.create_dataset(name=rand_gen(str), projects=project)
6052
dataset_2 = client.create_dataset(name=rand_gen(str), projects=project)
@@ -83,7 +75,6 @@ def test_label_filter_order(client, project, rand_gen, image_url):
8375
project.delete()
8476

8577

86-
@pytest.mark.skip("Cannot query for labels created with create_label")
8778
def test_label_bulk_deletion(project, rand_gen, image_url):
8879
dataset = project.client.create_dataset(name=rand_gen(str),
8980
projects=project)

tests/integration/test_labeler_performance.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import pytest
44

55

6-
@pytest.mark.skip(
7-
"Cannot query for labeler performance for labels created with create_label")
86
def test_labeler_performance(label_pack):
97
project, dataset, data_row, label = label_pack
108
# Sleep a bit as it seems labeler performance isn't updated immediately.

0 commit comments

Comments
 (0)