Merge pull request #123 from Labelbox/jtso/ontology

fixed bug where IDs were defaulting to a list rather than None. also …

Author: jtsodapop

labelbox/schema/ontology.py

@@ -42,8 +42,8 @@ def label(self):
     @classmethod
     def from_dict(cls, dictionary: Dict[str, Any]):
         return Option(value=dictionary["value"],
-                      schema_id=dictionary.get("schemaNodeId", []),
-                      feature_schema_id=dictionary.get("featureSchemaId", []),
+                      schema_id=dictionary.get("schemaNodeId", None),
+                      feature_schema_id=dictionary.get("featureSchemaId", None),
                       options=[
                           Classification.from_dict(o)
                           for o in dictionary.get("options", [])
@@ -123,10 +123,10 @@ def from_dict(cls, dictionary: Dict[str, Any]):
         return Classification(
             class_type=Classification.Type(dictionary["type"]),
             instructions=dictionary["instructions"],
-            required=dictionary["required"],
+            required=dictionary.get("required", False),
             options=[Option.from_dict(o) for o in dictionary["options"]],
-            schema_id=dictionary.get("schemaNodeId", []),
-            feature_schema_id=dictionary.get("featureSchemaId", []))
+            schema_id=dictionary.get("schemaNodeId", None),
+            feature_schema_id=dictionary.get("featureSchemaId", None))
 
     def asdict(self) -> Dict[str, Any]:
         if self.class_type in Classification._REQUIRES_OPTIONS \
@@ -201,9 +201,9 @@ class Type(Enum):
     @classmethod
     def from_dict(cls, dictionary: Dict[str, Any]):
         return Tool(name=dictionary['name'],
-                    schema_id=dictionary.get("schemaNodeId", []),
-                    feature_schema_id=dictionary.get("featureSchemaId", []),
-                    required=dictionary["required"],
+                    schema_id=dictionary.get("schemaNodeId", None),
+                    feature_schema_id=dictionary.get("featureSchemaId", None),
+                    required=dictionary.get("required", False),
                     tool=Tool.Type(dictionary["tool"]),
                     classifications=[
                         Classification.from_dict(c)