remove create_label

Author: Matt Sokoloff

Makefile

@@ -6,7 +6,7 @@ test-staging: build
 	docker run -it -v ${PWD}:/usr/src -w /usr/src \
 		-e LABELBOX_TEST_ENVIRON="staging" \
 		-e LABELBOX_TEST_API_KEY_STAGING=${LABELBOX_TEST_API_KEY_STAGING} \
-		local/labelbox-python:test pytest $(PATH_TO_TEST) -svvx
+		local/labelbox-python:test pytest $(PATH_TO_TEST) -svv
 
 test-prod: build
 	docker run -it -v ${PWD}:/usr/src -w /usr/src \

labelbox/schema/project.py

@@ -96,38 +96,6 @@ def members(self):
                                    {id_param: str(self.uid)},
                                    ["project", "members"], ProjectMember)
 
-    def create_label(self, **kwargs):
-        """ Creates a label on a Legacy Editor project. Not supported in the new Editor.
-        Args:
-            **kwargs: Label attributes. At minimum, the label `DataRow`.
-        """
-        # Copy-paste of Client._create code so we can inject
-        # a connection to Type. Type objects are on their way to being
-        # deprecated and we don't want the Py client lib user to know
-        # about them. At the same time they're connected to a Label at
-        # label creation in a non-standard way (connect via name).
-        logger.warning(
-            "`create_label` is deprecated and is not compatible with the new editor."
-        )
-
-        Label = Entity.Label
-
-        kwargs[Label.project] = self
-        kwargs[Label.seconds_to_label] = kwargs.get(Label.seconds_to_label.name,
-                                                    0.0)
-        data = {
-            Label.attribute(attr) if isinstance(attr, str) else attr:
-            value.uid if isinstance(value, DbObject) else value
-            for attr, value in kwargs.items()
-        }
-
-        query_str, params = query.create(Label, data)
-        # Inject connection to Type
-        query_str = query_str.replace(
-            "data: {", "data: {type: {connect: {name: \"Any\"}} ")
-        res = self.client.execute(query_str, params)
-        return Label(self.client, res["createLabel"])
-
     def labels(self, datasets=None, order_by=None):
         """ Custom relationship expansion method to support limited filtering.
 

tests/integration/conftest.py

@@ -1,6 +1,7 @@
 from collections import namedtuple
 from enum import Enum
 from datetime import datetime
+
 from random import randint
 from string import ascii_letters
 from types import SimpleNamespace
@@ -11,6 +12,9 @@
 
 from labelbox.orm.query import results_query_part
 from labelbox.schema.invite import Invite
+from labelbox.orm.db_object import DbObject
+from labelbox.orm.model import Entity
+from labelbox.orm import query
 from labelbox.pagination import PaginatedCollection
 from labelbox.schema.user import User
 from labelbox import LabelingFrontend
@@ -143,6 +147,26 @@ def gen(field_type):
 @pytest.fixture
 def project(client, rand_gen):
     project = client.create_project(name=rand_gen(str))
+    def create_label(**kwargs):
+        """ Creates a label on a Legacy Editor project. Not supported in the new Editor.
+        Args:
+            **kwargs: Label attributes. At minimum, the label `DataRow`.
+        """
+        Label = Entity.Label
+        kwargs[Label.project] = project
+        kwargs[Label.seconds_to_label] = kwargs.get(Label.seconds_to_label.name,
+                                                    0.0)
+        data = {
+            Label.attribute(attr) if isinstance(attr, str) else attr:
+            value.uid if isinstance(value, DbObject) else value
+            for attr, value in kwargs.items()
+        }
+        query_str, params = query.create(Label, data)
+        query_str = query_str.replace(
+            "data: {", "data: {type: {connect: {name: \"Any\"}} ")
+        res = project.client.execute(query_str, params)
+        return Label(project.client, res["createLabel"])
+    project.create_label = create_label
     yield project
     project.delete()
 

tests/integration/test_label.py

@@ -55,8 +55,7 @@ def test_label_update(label_pack):
     assert label.label == "something else"
 
 
-def test_label_filter_order(client, rand_gen):
-    project = client.create_project(name=rand_gen(str))
+def test_label_filter_order(client,project, rand_gen):
     dataset_1 = client.create_dataset(name=rand_gen(str), projects=project)
     dataset_2 = client.create_dataset(name=rand_gen(str), projects=project)
     data_row_1 = dataset_1.create_data_row(row_data=IMG_URL)