PR feedback

Author: Val Brodsky

libs/labelbox/src/labelbox/client.py

@@ -583,7 +583,6 @@ def _create(self, db_object_type, data, extra_params={}):
         """
         # Convert string attribute names to Field or Relationship objects.
         # Also convert Labelbox object values to their UIDs.
-
         data = {
             db_object_type.attribute(attr) if isinstance(attr, str) else attr:
                 value.uid if isinstance(value, DbObject) else value
@@ -761,11 +760,12 @@ def create_project(self, **kwargs) -> Project:
 
         return self._create(Entity.Project, params, extra_params)
 
-    def create_model_evalution_project(self,
-                                       dataset_name_or_id: str,
-                                       append_to_existing_dataset: bool = False,
-                                       data_row_count: int = 100,
-                                       **kwargs) -> Project:
+    def create_model_evaluation_project(
+            self,
+            dataset_name_or_id: str,
+            append_to_existing_dataset: bool = False,
+            data_row_count: int = 100,
+            **kwargs) -> Project:
         """
         Use this method exclusively to create a chat model evaluation project.
         Args:

libs/labelbox/src/labelbox/schema/project.py

@@ -133,7 +133,7 @@ class Project(DbObject, Updateable, Deletable):
     #
     _wait_processing_max_seconds = 3600
 
-    def is_chat_evalution(self) -> bool:
+    def is_chat_evaluation(self) -> bool:
         return self.media_type == MediaType.Conversational and self.editor_task_type == EditorTaskType.ModelChatEvaluation
 
     def update(self, **kwargs):
@@ -738,11 +738,11 @@ def setup_editor(self, ontology) -> None:
             ontology (Ontology): The ontology to attach to the project
         """
 
-        if self.labeling_frontend() is not None and not self.is_chat_evalution(
+        if self.labeling_frontend() is not None and not self.is_chat_evaluation(
         ):  # Chat evaluation projects are automatically set up via the same api that creates a project
             raise ResourceConflict("Editor is already set up.")
 
-        if not self.is_chat_evalution():
+        if not self.is_chat_evaluation():
             labeling_frontend = next(
                 self.client.get_labeling_frontends(
                     where=Entity.LabelingFrontend.name == "Editor"))
@@ -787,7 +787,7 @@ def setup(self, labeling_frontend, labeling_frontend_options) -> None:
                 to `str` using `json.dumps`.
         """
 
-        if self.is_chat_evalution():
+        if self.is_chat_evaluation():
             warnings.warn("""
             This project is a chat evaluation project.
             Editor was setup automatically.

libs/labelbox/tests/integration/conftest.py

@@ -366,7 +366,7 @@ def chat_evaluation_ontology(client, rand_gen):
 def chat_evaluation_project(client, rand_gen):
     project_name = f"test-model-evaluation-project-{rand_gen(str)}"
     dataset_name_or_id = f"test-model-evaluation-dataset-{rand_gen(str)}"
-    project = client.create_model_evalution_project(
+    project = client.create_model_evaluation_project(
         name=project_name, dataset_name_or_id=dataset_name_or_id)
 
     yield project

libs/labelbox/tests/integration/test_chat_evaluation_ontology_project.py

@@ -19,11 +19,6 @@ def test_create_chat_evaluation_ontology_project(client,
         assert tool.feature_schema_id
 
     project = chat_evaluation_project
-    # editor = list(
-    #     client.get_labeling_frontends(
-    #         where=LabelingFrontend.name == "editor"))[0]
-    # project.setup(editor, ontology)
-
     project.setup_editor(ontology)
 
     assert project.labeling_frontend().name == "Editor"