Merge pull request #356 from Labelbox/DIAG-1131

update to project upsert instructions to no longer remove old ontolog…

Author: jtsodapop

labelbox/schema/project.py

@@ -346,7 +346,7 @@ def upsert_instructions(self, instructions_file: str):
 
         lfo = list(self.labeling_frontend_options())[-1]
         instructions_url = self.client.upload_file(instructions_file)
-        customization_options = json.loads(lfo.customization_options)
+        customization_options = self.ontology().normalized
         customization_options['projectInstructions'] = instructions_url
         option_id = lfo.uid
 

tests/data/assets/loremipsum.pdf

@@ -103,6 +103,19 @@ def test_attach_instructions(client, project):
     assert "instructions_file must end with one of" in str(exc_info.value)
 
 
+def test_same_ontology_after_instructions(
+        client, configured_project_with_complex_ontology):
+    project, _ = configured_project_with_complex_ontology
+    initial_ontology = project.ontology().normalized
+    project.upsert_instructions('tests/data/assets/loremipsum.pdf')
+    updated_ontology = project.ontology().normalized
+
+    instructions = updated_ontology.pop('projectInstructions')
+
+    assert initial_ontology == updated_ontology
+    assert instructions is not None
+
+
 def test_queued_data_row_export(configured_project):
     result = configured_project.export_queued_data_rows()
     assert len(result) == 1