Merge pull request #705 from Labelbox/kkim/AL-3545

[AL-3545] Remove get_data_rows_for_global_keys on initial release

Author: kkim-labelbox

labelbox/client.py

@@ -1192,45 +1192,3 @@ def _format_failed_rows(rows: List[str],
                     "Timed out waiting for get_data_rows_for_global_keys job to complete."
                 )
             time.sleep(sleep_time)
-
-    def get_data_rows_for_global_keys(
-            self,
-            global_keys: List[str],
-            timeout_seconds=60) -> Dict[str, Union[str, List[Any]]]:
-        """
-        Gets data rows for a list of global keys.
-
-        Args:
-            A list of global keys
-        Returns:
-            Dictionary containing 'status', 'results' and 'errors'.
-
-            'Status' contains the outcome of this job. It can be one of
-            'Success', 'Partial Success', or 'Failure'.
-
-            'Results' contains a list of `DataRow` instances successfully fetchced. It may
-            not necessarily contain all data rows requested.
-
-            'Errors' contains a list of global_keys that could not be fetched, along
-            with the failure reason
-        Examples:
-            >>> job_result = client.get_data_rows_for_global_keys(["key1","key2"])
-            >>> print(job_result['status'])
-            Partial Success
-            >>> print(job_result['results'])
-            [<DataRow ID: cl7tvvybc00icka6ggipyh8tj>, <DataRow ID: cl7tvvyfp00igka6gblrw2idc>]
-            >>> print(job_result['errors'])
-            [{'global_key': 'asdf', 'error': 'Data Row not found'}]
-        """
-        job_result = self.get_data_row_ids_for_global_keys(
-            global_keys, timeout_seconds)
-
-        # Query for data row by data_row_id to ensure we get all fields populated in DataRow instances
-        data_rows = []
-        for data_row_id in job_result['results']:
-            # TODO: Need to optimize this to run over a collection of data_row_ids
-            data_rows.append(self.get_data_row(data_row_id))
-
-        job_result['results'] = data_rows
-
-        return job_result

tests/integration/test_global_keys.py

@@ -147,6 +147,8 @@ def test_global_key_with_whitespaces_validation(client, dataset, image_url):
         ['Invalid global key', 'Invalid global key', 'Invalid global key'])
 
 
+@pytest.mark.skip(reason='get_data_rows_for_global_keys not included in '
+                  'the initial release of global_keys')
 def test_get_data_rows_for_global_keys(client, dataset, image_url):
     gk_1 = str(uuid.uuid4())
     gk_2 = str(uuid.uuid4())
@@ -174,6 +176,8 @@ def test_get_data_rows_for_global_keys(client, dataset, image_url):
     assert res['results'] == [dr_1, dr_2]
 
 
+@pytest.mark.skip(reason='get_data_rows_for_global_keys not included in '
+                  'the initial release of global_keys')
 def test_get_data_rows_for_invalid_global_keys(client, dataset, image_url):
     gk_1 = str(uuid.uuid4())
     gk_2 = str(uuid.uuid4())