Skip to content

Commit 6ebc2ea

Browse files
committed
update to tests and error handling
1 parent 39d4a34 commit 6ebc2ea

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

labelbox/client.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,17 +1014,14 @@ def assign_global_keys_to_data_rows(
10141014
if res['invalidGlobalKeyAssignments']:
10151015
errors.append("Invalid Global Keys: " +
10161016
str(res['invalidGlobalKeyAssignments']))
1017-
if res['unmodifiedAssignments']:
1018-
errors.append("Unmodified Assignments: " +
1019-
str(res['unmodifiedAssignments']))
10201017
if res['accessDeniedAssignments']:
10211018
errors.append("Access Denied Assignments: " +
10221019
str(res['accessDeniedAssignments']))
10231020
if len(errors) > 0:
10241021
raise Exception(
10251022
"Failed to assign global keys to data rows: " +
10261023
str(errors))
1027-
return res['sanitizedAssignments']
1024+
return res['sanitizedAssignments'] + res['unmodifiedAssignments']
10281025
time.sleep(2)
10291026
timeout -= 2
10301027

tests/integration/test_assign_global_key_to_data_row.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def test_assign_global_keys_to_data_rows(client, dataset, image_url):
1010

1111
dr_1 = dataset.create_data_row(row_data=image_url, external_id="hello")
1212
dr_2 = dataset.create_data_row(row_data=image_url, external_id="world")
13-
row_ids = [dr_1.uid, dr_2.uid]
13+
row_ids = set([dr_1.uid, dr_2.uid])
1414

1515
gk_1 = str(uuid.uuid4())
1616
gk_2 = str(uuid.uuid4())
@@ -24,5 +24,5 @@ def test_assign_global_keys_to_data_rows(client, dataset, image_url):
2424
res = client.get_data_row_ids_for_global_keys([gk_1, gk_2])
2525

2626
assert len(res) == 2
27-
for row in res:
28-
assert row['id'] in row_ids
27+
successful_assignments = set(a['id'] for a in res)
28+
assert successful_assignments == row_ids

0 commit comments

Comments
 (0)