Flake8

Author: feynmanliang

Pipfile

@@ -20,6 +20,7 @@ xmltodict = "*"
 check-manifest = "*"
 mypy = "*"
 docutils = "*"
+"flake8" = "*"
 
 [requires]
 python_version = "3.6"

Pipfile.lock

@@ -2,6 +2,7 @@
 Exception classes for the labelbox python package.
 """
 
+
 class UnknownFormatError(Exception):
     """Exception raised for unknown label_format"""
 

labelbox/exceptions.py

@@ -44,6 +44,7 @@ def from_json(labeled_data, coco_output, label_format='WKT'):
     with open(coco_output, 'w+') as file_handle:
         file_handle.write(json.dumps(coco))
 
+
 def make_coco_metadata(project_name, created_by):
     "Initializes COCO export data structure."
     coco = {
@@ -65,6 +66,7 @@ def make_coco_metadata(project_name, created_by):
 
     return coco
 
+
 def _add_label(coco, image, labels, label_format):
     "Incrementally updates COCO export data structure with a new label."
     response = requests.get(image['coco_url'], stream=True)
@@ -114,23 +116,24 @@ def _add_label(coco, image, labels, label_format):
 
             coco['annotations'].append(annotation)
 
+
 def _get_polygons(label_format, label_data):
     "Converts segmentation `label: String!` into polygons"
     if label_format == 'WKT':
-        if isinstance(label_data, list): # V3
+        if isinstance(label_data, list):  # V3
             polygons = map(lambda x: wkt.loads(x['geometry']), label_data)
-        else: # V2
+        else:  # V2
             polygons = wkt.loads(label_data)
     elif label_format == 'XY':
         polygons = []
         for xy_list in label_data:
-            if 'geometry' in xy_list: # V3
+            if 'geometry' in xy_list:  # V3
                 xy_list = xy_list['geometry']
 
                 # V2 and V3
                 assert isinstance(xy_list, list), \
-                        'Expected list in "geometry" key but got {}'.format(xy_list)
-            else: # V2, or non-list
+                    'Expected list in "geometry" key but got {}'.format(xy_list)
+            else:  # V2, or non-list
                 if not isinstance(xy_list, list) or not xy_list or 'x' not in xy_list[0]:
                     # skip non xy lists
                     continue

labelbox/exporters/coco_exporter.py

@@ -53,6 +53,7 @@ def from_json(labeled_data, annotations_output_dir, images_output_dir,
             logging.exception('Failed to fetch image from %s', data['Labeled Data'])
             continue
 
+
 def _write_label(
         data, label_format, images_output_dir, annotations_output_dir):
     "Writes a Pascal VOC formatted image and label pair to disk."
@@ -94,16 +95,16 @@ def _write_label(
 
 def _add_pascal_object_from_wkt(xml_writer, img_height, wkt_data, label):
     polygons = []
-    if isinstance(wkt_data, list): # V3+
+    if isinstance(wkt_data, list):  # V3+
         polygons = map(lambda x: wkt.loads(x['geometry']), wkt_data)
-    else: # V2
+    else:  # V2
         polygons = wkt.loads(wkt_data)
 
     for point in polygons:
         xy_coords = []
         for x_val, y_val in point.exterior.coords:
             xy_coords.extend([x_val, img_height - y_val])
-	# remove last polygon if it is identical to first point
+        # remove last polygon if it is identical to first point
         if xy_coords[-2:] == xy_coords[:2]:
             xy_coords = xy_coords[:-2]
         xml_writer.add_object(name=label, xy_coords=xy_coords)
@@ -112,9 +113,9 @@ def _add_pascal_object_from_wkt(xml_writer, img_height, wkt_data, label):
 
 def _add_pascal_object_from_xy(xml_writer, img_height, polygons, label):
     for polygon in polygons:
-        if 'geometry' in polygon: # V3
+        if 'geometry' in polygon:  # V3
             polygon = polygon['geometry']
-        assert isinstance(polygon, list) # V2 and V3
+        assert isinstance(polygon, list)  # V2 and V3
 
         xy_coords = []
         for point in polygon:

labelbox/exporters/voc_exporter.py

@@ -4,7 +4,7 @@
 import collections
 
 import rasterio.features
-from simplification.cutil import simplify_coords # pylint: disable=no-name-in-module
+from simplification.cutil import simplify_coords  # pylint: disable=no-name-in-module
 
 
 def vectorize_to_v4_label(segmentation_map, legend, epsilon=None):
@@ -33,7 +33,7 @@ class names.
         in image-segmentation v4 frontend after calling `json.dumps`.
     """
     assert len(segmentation_map.shape) == 2, \
-            'Segmentation maps must be numpy arrays with shape (width, height)'
+        'Segmentation maps must be numpy arrays with shape (width, height)'
     label = collections.defaultdict(lambda: [])
     for polygon, pixel_value in rasterio.features.shapes(segmentation_map):
         pixel_value = int(pixel_value)

labelbox/predictions/__init__.py

@@ -82,7 +82,7 @@ source_dir = docs
 build_dir = docs/_build
 
 [flake8]
-# Some sane defaults for the code style checker flake8
+max-line-length = 120
 exclude =
     .tox
     build

setup.cfg

@@ -1,3 +1,4 @@
 from setuptools import setup
 
+# configured in setup.cfg
 setup()

setup.py

@@ -6,6 +6,7 @@
 import labelbox.exporters.coco_exporter as lb2co
 import labelbox.exporters.voc_exporter as lb2pa
 
+
 class TestCocoExporter(object):
     def test_labelbox_1(self, tmpfile, datadir):
         labeled_data = datadir.join('labelbox_1.json')
@@ -40,6 +41,7 @@ def test_empty_skipped(self, tmpfile, datadir):
         labeled_data = datadir.join('empty_skipped.json')
         lb2co.from_json(labeled_data=labeled_data, coco_output=tmpfile)
 
+
 class TestVocExporter(object):
     def test_wkt_1(self, tmpdir, datadir):
         labeled_data = datadir.join('labelbox_1.json')

tests/test_exporters.py

@@ -3,12 +3,13 @@
 
 import labelbox.predictions as lbpreds
 
+
 def test_vectorize_to_v4_label():
-    segmentation_map = np.zeros((256,256), dtype=np.int32)
-    segmentation_map[:32,:32] = 1 # top left corner
-    segmentation_map[32:128,:32] = 2 # strip from top left to top middle
-    segmentation_map[:64,-32:] = 3 # left half of bottom
-    segmentation_map[-64:,-32:] = 3 # right half of bottom
+    segmentation_map = np.zeros((256, 256), dtype=np.int32)
+    segmentation_map[:32, :32] = 1  # top left corner
+    segmentation_map[32:128, :32] = 2  # strip from top left to top middle
+    segmentation_map[:64, -32:] = 3  # left half of bottom
+    segmentation_map[-64:, -32:] = 3  # right half of bottom
 
     legend = {
             1: 'TL',
@@ -23,7 +24,7 @@ def test_vectorize_to_v4_label():
     assert set(legend.values()).issuperset(label.keys())
 
     # contains top left, and has (0,0)
-    assert any(map(lambda x: x['geometry'][0] == {'x':0, 'y':0}, label['TL']))
+    assert any(map(lambda x: x['geometry'][0] == {'x': 0, 'y': 0}, label['TL']))
     assert len(label['TL']) == 1
 
     # two regions, bottom left and bottom right
@@ -32,8 +33,8 @@ def test_vectorize_to_v4_label():
     # does not contain unannotated class
     assert 'NO_LABELS' not in label.keys()
 
+
 def test_vectorize_simplify():
-# Using Ramer–Douglas–Peucker
     coords = [
         (0.0, 0.0),
         (5.0, 4.0),