Remove result_all error_all

Author: Val Brodsky

libs/labelbox/src/labelbox/schema/task.py

@@ -242,7 +242,8 @@ def __init__(self, *args, **kwargs):
     @property
     def result(self) -> Optional[List[Dict[str, Any]]]:  # type: ignore
         """
-        Fetches maximum 150K results. If you need to fetch more, use `result_all` property
+        Fetches all results.
+        Note, for large uploads (>150K data rows), it could take multiple minutes to complete
         """
         if self.status == "FAILED":
             raise ValueError(f"Job failed. Errors : {self.errors}")
@@ -251,7 +252,8 @@ def result(self) -> Optional[List[Dict[str, Any]]]:  # type: ignore
     @property
     def errors(self) -> Optional[List[Dict[str, Any]]]:  # type: ignore
         """
-        Fetches maximum 150K errors. If you need to fetch more, use `errors_all` property
+        Fetches all errors.
+        Note, for large uploads / large number of errors (>150K), it could take multiple minutes to complete
         """
         return self._errors_as_list()
 
@@ -265,23 +267,6 @@ def failed_data_rows(  # type: ignore
             self) -> Optional[List[Dict[str, Any]]]:
         return self.errors
 
-    @property
-    def result_all(self) -> PaginatedCollection:
-        """
-        This method uses our standard PaginatedCollection and allow to fetch any number of results
-        See here for more https://docs.labelbox.com/reference/sdk-fundamental-concepts-1#iterate-over-paginatedcollection
-        """
-        return self._download_results_paginated()
-
-    @property
-    def errors_all(self) -> PaginatedCollection:
-        """
-        This method uses our standard PaginatedCollection and allow to fetch any number of errors
-        See here for more https://docs.labelbox.com/reference/sdk-fundamental-concepts-1#iterate-over-paginatedcollection
-        """
-
-        return self._download_errors_paginated()
-
     def _download_results_paginated(self) -> PaginatedCollection:
         page_size = DOWNLOAD_RESULT_PAGE_SIZE
         from_cursor = None
@@ -389,8 +374,6 @@ def _results_as_list(self) -> Optional[List[Dict[str, Any]]]:
         for row in data:
             results.append(row)
             total_downloaded += 1
-            if total_downloaded >= self.MAX_DOWNLOAD_SIZE:
-                break
 
         if len(results) == 0:
             return None
@@ -405,8 +388,6 @@ def _errors_as_list(self) -> Optional[List[Dict[str, Any]]]:
         for row in data:
             errors.append(row)
             total_downloaded += 1
-            if total_downloaded >= self.MAX_DOWNLOAD_SIZE:
-                break
 
         if len(errors) == 0:
             return None

libs/labelbox/tests/integration/test_data_rows.py

@@ -196,9 +196,6 @@ def test_data_row_bulk_creation(dataset, rand_gen, image_url):
         assert len(results) == 2
         row_data = [result["row_data"] for result in results]
         assert row_data == [image_url, image_url]
-        results_all = task.result_all
-        row_data = [result["row_data"] for result in results_all]
-        assert row_data == [image_url, image_url]
 
         data_rows = list(dataset.data_rows())
         assert len(data_rows) == 2
@@ -237,7 +234,7 @@ def test_data_row_bulk_creation_from_file(dataset, local_image_file, image_url):
         assert task.status == "COMPLETE"
         assert len(task.result) == 2
         assert task.has_errors() is False
-        results = [r for r in task.result_all]
+        results = task.result
         row_data = [result["row_data"] for result in results]
         assert len(row_data) == 2
 
@@ -257,7 +254,7 @@ def test_data_row_bulk_creation_from_row_data_file_external_id(
         assert task.status == "COMPLETE"
         assert len(task.result) == 2
         assert task.has_errors() is False
-        results = [r for r in task.result_all]
+        results = task.result
         row_data = [result["row_data"] for result in results]
         assert len(row_data) == 2
         assert image_url in row_data
@@ -276,7 +273,7 @@ def test_data_row_bulk_creation_from_row_data_file(dataset, rand_gen,
         assert task.status == "COMPLETE"
         assert len(task.result) == 2
         assert task.has_errors() is False
-        results = [r for r in task.result_all]
+        results = task.result
         row_data = [result["row_data"] for result in results]
         assert len(row_data) == 2
 
@@ -980,12 +977,10 @@ def test_data_row_bulk_creation_with_same_global_keys(dataset, sample_image,
     assert task.created_data_rows[0]['external_id'] == sample_image
     assert task.created_data_rows[0]['global_key'] == global_key_1
 
-    errors = task.errors_all
-    all_errors = [er for er in errors]
-    assert len(all_errors) == 1
+    assert len(task.errors) == 1
     assert task.has_errors() is True
 
-    all_results = [result for result in task.result_all]
+    all_results = task.result
     assert len(all_results) == 1