FIX: parse metadata changes

Author: gdj0nes

labelbox/schema/data_row_metadata.py

@@ -194,10 +194,13 @@ def parse_metadata(
 
         """
         parsed = []
+        if isinstance(unparsed, dict):
+            raise ValueError("Pass a list of dictionaries")
+
         for dr in unparsed:
             fields = []
             for f in dr["fields"]:
-                schema = self.all_fields_id_index[f["schemaId"]]
+                schema = self.all_fields_id_index[f["schema_id"]]
                 if schema.kind == DataRowMetadataKind.enum:
                     continue
                 elif schema.kind == DataRowMetadataKind.option:
@@ -209,7 +212,7 @@ def parse_metadata(
 
                 fields.append(field)
             parsed.append(
-                DataRowMetadata(data_row_id=dr["dataRowId"], fields=fields))
+                DataRowMetadata(data_row_id=dr["data_row_id"], fields=fields))
         return parsed
 
     def bulk_upsert(
@@ -371,8 +374,8 @@ def _validate_delete(self, delete: DeleteDataRowMetadata):
             deletes.add(schema.id)
 
         return _DeleteBatchDataRowMetadata(
-            dataRowId=delete.data_row_id,
-            schemaIds=list(delete.fields)).dict(by_alias=True)
+            data_row_id=delete.data_row_id,
+            schema_ids=list(delete.fields)).dict(by_alias=True)
 
 
 def _batch_items(iterable: List[Any], size: int) -> Generator[Any, None, None]:

tests/integration/test_data_row_metadata.py

@@ -3,7 +3,8 @@
 import pytest
 
 from labelbox import DataRow, Dataset
-from labelbox.schema.data_row_metadata import DataRowMetadataField, DataRowMetadata, DeleteDataRowMetadata
+from labelbox.schema.data_row_metadata import DataRowMetadataField, DataRowMetadata, DeleteDataRowMetadata, \
+    DataRowMetadataOntology
 
 IMG_URL = "https://picsum.photos/id/829/200/300"
 FAKE_SCHEMA_ID = "0" * 25
@@ -23,11 +24,11 @@ def mdo(client):
 @pytest.fixture
 def big_dataset(dataset: Dataset):
     task = dataset.create_data_rows([
-        {
-            "row_data": IMG_URL,
-            "external_id": "my-image"
-        },
-    ] * 1000)
+                                        {
+                                            "row_data": IMG_URL,
+                                            "external_id": "my-image"
+                                        },
+                                    ] * 1000)
     task.wait_till_done()
 
     yield dataset
@@ -65,13 +66,20 @@ def test_get_datarow_metadata(datarow):
     assert len(md)
 
 
-def test_bulk_upsert_datarow_metadata(datarow, mdo):
+def test_bulk_upsert_datarow_metadata(datarow, mdo: DataRowMetadataOntology):
     assert not len(datarow.metadata["fields"])
     metadata = make_metadata(datarow.uid)
     mdo.bulk_upsert([metadata])
     assert len(datarow.metadata["fields"])
 
 
+def test_parse_upsert_datarow_metadata(datarow, mdo: DataRowMetadataOntology):
+    assert not len(datarow.metadata["fields"])
+    metadata = make_metadata(datarow.uid)
+    mdo.bulk_upsert([metadata])
+    assert mdo.parse_metadata([datarow.metadata])
+
+
 @pytest.mark.slow
 def test_large_bulk_upsert_datarow_metadata(big_dataset, mdo):
     metadata = []