requested changes

Author: Matt Sokoloff

labelbox/schema/project.py

@@ -173,7 +173,7 @@ def export_labels(self, timeout_seconds=60):
                          self.uid)
             time.sleep(sleep_time)
 
-    def attach_instructions(self, instructions_file: str):
+    def upsert_instructions(self, instructions_file: str):
         """
         * Uploads instructions to the UI. Running more than once will replace the instructions
             
@@ -189,16 +189,16 @@ def attach_instructions(self, instructions_file: str):
 
         if self.setup_complete is None:
             raise ValueError(
-                "Cannot attach instructions to a project that has not been setup."
+                "Cannot attach instructions to a project that has not been set up."
             )
 
         frontend = self.labeling_frontend()
         frontendId = frontend.uid
 
         if frontend.name != "Editor":
             logger.warn(
-                f"This function has only been tested to work with the Editor front end. Found {frontend.name}"
-            )
+                f"This function has only been tested to work with the Editor front end. Found %s",
+                frontend.name)
 
         supported_instruction_formats = (".text", ".txt", ".pdf", ".html")
         if not instructions_file.endswith(supported_instruction_formats):

tests/integration/test_project.py

@@ -1,5 +1,6 @@
 import pytest
 import json
+import requests
 
 from labelbox import Project, LabelingFrontend
 from labelbox.exceptions import InvalidQueryError
@@ -68,8 +69,11 @@ def test_extend_reservations(project):
 
 
 def test_attach_instructions(client, project):
-    with pytest.raises(ValueError):
-        project.attach_instructions('/tmp/instructions.txt')
+    with pytest.raises(ValueError) as execinfo:
+        project.upsert_instructions('/tmp/instructions.txt')
+    assert str(
+        execinfo.value
+    ) == "Cannot attach instructions to a project that has not been set up."
 
     editor = list(
         client.get_labeling_frontends(
@@ -80,10 +84,11 @@ def test_attach_instructions(client, project):
     with open('/tmp/instructions.txt', 'w') as file:
         file.write("some instructions...")
 
-    project.attach_instructions('/tmp/instructions.txt')
+    project.upsert_instructions('/tmp/instructions.txt')
     assert json.loads(
         list(project.labeling_frontend_options())
         [-1].customization_options).get('projectInstructions') is not None
 
-    with pytest.raises(ValueError):
-        project.attach_instructions('/tmp/file.invalid_file_extension')
+    with pytest.raises(ValueError) as execinfo:
+        project.upsert_instructions('/tmp/file.invalid_file_extension')
+    assert "instructions_file must end with one of" in str(execinfo.value)