Make Label.seconds_to_label optional in Label creation.

Author: florijanstamenkovic

CHANGELOG.md

@@ -7,6 +7,8 @@
 returned `dict`. This *breaks* existing code that directly uses the
 `Client.execute` method.
 * Major code reorganization, naming and test improvements.
+* `Label.seconds_to_label` field value is now optional when creating
+a `Label`. Default value is 0.0.
 
 ### Added
 * `Project.upsert_review_queue` method.

labelbox/schema/project.py

@@ -44,8 +44,7 @@ class Project(DbObject, Updateable, Deletable):
     def create_label(self, **kwargs):
         """ Creates a label on this Project.
         Kwargs:
-            Label attributes. At the minimum the label `DataRow`
-            relationship and `seconds_to_label` field.
+            Label attributes. At the minimum the label `DataRow`.
         """
         # Copy-paste of Client._create code so we can inject
         # a connection to Type. Type objects are on their way to being
@@ -54,7 +53,10 @@ def create_label(self, **kwargs):
         # label creation in a non-standard way (connect via name).
 
         Label = Entity.Label
+
         kwargs[Label.project] = self
+        kwargs[Label.seconds_to_label] = kwargs.get(
+            Label.seconds_to_label.name, 0.0)
         data = {Label.attribute(attr) if isinstance(attr, str) else attr:
                 value.uid if isinstance(value, DbObject) else value
                 for attr, value in kwargs.items()}

tests/integration/conftest.py

@@ -72,7 +72,6 @@ def label_pack(project, rand_gen):
     client = project.client
     dataset = client.create_dataset(name=rand_gen(str), projects=project)
     data_row = dataset.create_data_row(row_data=IMG_URL)
-    label = project.create_label(data_row=data_row, label=rand_gen(str),
-                                 seconds_to_label=0.0)
+    label = project.create_label(data_row=data_row, label=rand_gen(str))
     yield LabelPack(project, dataset, data_row, label)
     dataset.delete()

tests/integration/test_label.py

@@ -33,7 +33,7 @@ def test_labels(label_pack):
 
 def test_label_export(label_pack):
     project, dataset, data_row, label = label_pack
-    project.create_label(data_row=data_row, label="l2", seconds_to_label=0.3)
+    project.create_label(data_row=data_row, label="l2")
 
     exported_labels_url = project.export_labels(5)
     assert exported_labels_url is not None
@@ -57,10 +57,8 @@ def test_label_filter_order(client, rand_gen):
     data_row_1 = dataset_1.create_data_row(row_data=IMG_URL)
     data_row_2 = dataset_2.create_data_row(row_data=IMG_URL)
 
-    l1 = project.create_label(data_row=data_row_1, label="l1",
-                              seconds_to_label=0.3)
-    l2 = project.create_label(data_row=data_row_2, label="l2",
-                              seconds_to_label=0.1)
+    l1 = project.create_label(data_row=data_row_1, label="l1")
+    l2 = project.create_label(data_row=data_row_2, label="l2")
 
     # Labels are not visible in the project immediately.
     time.sleep(10)
@@ -74,8 +72,6 @@ def test_label_filter_order(client, rand_gen):
 
     assert list(project.labels(order_by=Label.label.asc)) == [l1, l2]
     assert list(project.labels(order_by=Label.label.desc)) == [l2, l1]
-    assert list(project.labels(order_by=Label.seconds_to_label.asc)) == [l2, l1]
-    assert list(project.labels(order_by=Label.seconds_to_label.desc)) == [l1, l2]
 
     dataset_1.delete()
     dataset_2.delete()
@@ -87,9 +83,9 @@ def test_label_bulk_deletion(project, rand_gen):
     row_1 = dataset.create_data_row(row_data=IMG_URL)
     row_2 = dataset.create_data_row(row_data=IMG_URL)
 
-    l1 = project.create_label(data_row=row_1, label="l1", seconds_to_label=0.3)
-    l2 = project.create_label(data_row=row_1, label="l2", seconds_to_label=0.1)
-    l3 = project.create_label(data_row=row_2, label="l3", seconds_to_label=0.1)
+    l1 = project.create_label(data_row=row_1, label="l1")
+    l2 = project.create_label(data_row=row_1, label="l2")
+    l3 = project.create_label(data_row=row_2, label="l3")
 
     # Labels are not visible in the project immediately.
     time.sleep(10)

tests/integration/test_review.py

@@ -48,8 +48,7 @@ def test_review_metrics(label_pack):
 
     for count, score in ((4, 0), (2, 1), (3, -1)):
         for _ in range(count):
-            l = project.create_label(data_row=data_row, label="l",
-                                     seconds_to_label=0.0)
+            l = project.create_label(data_row=data_row, label="l")
             l.create_review(score=score)
 
     assert project.review_metrics(None) == 1